[Model] Refactor Step3-VL processor to HF style#37579
Merged
DarkLight1337 merged 7 commits intovllm-project:mainfrom Mar 20, 2026
Merged
[Model] Refactor Step3-VL processor to HF style#37579DarkLight1337 merged 7 commits intovllm-project:mainfrom
DarkLight1337 merged 7 commits intovllm-project:mainfrom
Conversation
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors the Step3-VL processor to align with the Hugging Face style by separating the image processing logic into its own class. While the refactoring is a good step towards better code organization, I've identified a critical bug in the new processor's __call__ method that would cause a runtime error. Additionally, there's a high-severity functional regression due to the removal of a method, which results in less accurate image token counting. I have provided detailed comments and code suggestions to address both of these issues.
Member
Author
|
Ready for review |
Isotr0py
approved these changes
Mar 20, 2026
chooper26
pushed a commit
to intellistream/vllm-hust
that referenced
this pull request
Mar 21, 2026
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
image_processorin order to fit HF call semantics.Test Plan
Checked using the example script
Test Result
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.