Skip to content

[Log] Log once in local node by default#37568

Merged
simon-mo merged 1 commit intomainfrom
wentao-default-log-scope-local
Mar 19, 2026
Merged

[Log] Log once in local node by default#37568
simon-mo merged 1 commit intomainfrom
wentao-default-log-scope-local

Conversation

@yewentao256
Copy link
Copy Markdown
Member

@yewentao256 yewentao256 commented Mar 19, 2026

Purpose

If we call log_once, namely we want to log once instead of having duplicate logs per process.

We have a lot of fixes like #37313

But maybe switching to "local" by default be a better idea.

Signed-off-by: yewentao256 <zhyanwentao@126.com>
@yewentao256 yewentao256 added the ready ONLY add when PR is ready to merge/full CI is needed label Mar 19, 2026
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

The pull request changes the default logging scope for debug_once, info_once, and warning_once methods from "process" to "local". This means that by default, these logging calls will now only be executed on the local first rank (is_local_first_rank()) instead of once per process. While the intent is to reduce duplicate logs, changing the default for info_once and especially warning_once to a more restrictive scope could lead to important information or warnings being missed on other local ranks. This could make debugging distributed setups significantly harder, as critical events might only be visible on a single rank. It is generally safer for info and warning level logs to be visible across all relevant processes unless explicitly configured otherwise.

@simon-mo simon-mo merged commit 7454096 into main Mar 19, 2026
49 checks passed
@simon-mo simon-mo deleted the wentao-default-log-scope-local branch March 19, 2026 19:05
chooper26 pushed a commit to intellistream/vllm-hust that referenced this pull request Mar 21, 2026
Signed-off-by: yewentao256 <zhyanwentao@126.com>
SouthWest7 pushed a commit to SouthWest7/vllm that referenced this pull request Mar 27, 2026
Signed-off-by: yewentao256 <zhyanwentao@126.com>
khairulkabir1661 pushed a commit to khairulkabir1661/vllm that referenced this pull request Mar 27, 2026
Signed-off-by: yewentao256 <zhyanwentao@126.com>
Monishver11 pushed a commit to Monishver11/vllm that referenced this pull request Mar 27, 2026
Signed-off-by: yewentao256 <zhyanwentao@126.com>
Signed-off-by: Monishver Chandrasekaran <monishverchandrasekaran@gmail.com>
JiantaoXu pushed a commit to JiantaoXu/vllm that referenced this pull request Mar 28, 2026
Signed-off-by: yewentao256 <zhyanwentao@126.com>
vrdn-23 pushed a commit to vrdn-23/vllm that referenced this pull request Mar 30, 2026
Signed-off-by: yewentao256 <zhyanwentao@126.com>
Signed-off-by: Vinay Damodaran <vrdn@hey.com>
EricccYang pushed a commit to EricccYang/vllm that referenced this pull request Apr 1, 2026
Signed-off-by: yewentao256 <zhyanwentao@126.com>
Signed-off-by: EricccYang <yangyang4991@gmail.com>
liuchenbing2026 pushed a commit to liuchenbing2026/vllm that referenced this pull request Apr 4, 2026
Signed-off-by: yewentao256 <zhyanwentao@126.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants