Skip to content

[Refactor] Relocate tests from tests/v1/entrypoints/ to tests/entrypoints/#37500

Merged
DarkLight1337 merged 4 commits intovllm-project:mainfrom
sfeng33:relo-tests
Mar 20, 2026
Merged

[Refactor] Relocate tests from tests/v1/entrypoints/ to tests/entrypoints/#37500
DarkLight1337 merged 4 commits intovllm-project:mainfrom
sfeng33:relo-tests

Conversation

@sfeng33
Copy link
Contributor

@sfeng33 sfeng33 commented Mar 19, 2026

Purpose

Consolidate tests so that all entrypoint tests are centralized in the same folder:

  • Move test_struct_output_generate.py to tests/entrypoints/llm/
  • Move test_chat_completion.py, test_completion_with_image_embeds.py to
    tests/entrypoints/openai/chat_completion/
  • Move test_completion.py to tests/entrypoints/openai/completion/
  • Move test_multi_api_servers.py to tests/entrypoints/openai/
  • Delete tests/v1/entrypoints/

CI changes

  • Update all path references in .buildkite/ configs, CODEOWNERS, and mergify.yml
  • Remove dedicated "V1 Test entrypoints" jobs from AMD CI (tests are now covered by existing entrypoints jobs)
  • Add --ignore=entrypoints/openai/test_multi_api_servers.py to broad entrypoints/openai sweeps in entrypoints.yaml and test-amd.yaml to prevent double-running (it's already run explicitly with DP_SIZE=2 in distributed CI)

@sfeng33 sfeng33 marked this pull request as ready for review March 19, 2026 01:58
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request effectively relocates test files from tests/v1/entrypoints/ to tests/entrypoints/ and updates all corresponding path references in .buildkite configurations, CODEOWNERS, and mergify.yml. The changes also correctly remove dedicated "V1 Test entrypoints" jobs from CI, ensuring that tests are now covered by existing entrypoints jobs and preventing double-running of test_multi_api_servers.py. The consolidation of test files and associated configuration updates are well-executed and align with the stated purpose of centralizing entrypoint tests, improving the overall organization and maintainability of the test suite.

Copy link
Member

@DarkLight1337 DarkLight1337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense but would like @robertgshaw2-redhat to take a look, as I'm not 100% sure what was the original intention of V1 entrypoints tests

@mergify
Copy link

mergify bot commented Mar 19, 2026

This pull request has merge conflicts that must be resolved before it can be
merged. Please rebase the PR, @sfeng33.

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

@robertgshaw2-redhat robertgshaw2-redhat enabled auto-merge (squash) March 19, 2026 21:45
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Mar 19, 2026
auto-merge was automatically disabled March 19, 2026 22:23

Head branch was pushed to by a user without write access

@robertgshaw2-redhat robertgshaw2-redhat added the rocm Related to AMD ROCm label Mar 20, 2026
@github-project-automation github-project-automation bot moved this to Todo in AMD Mar 20, 2026
sfeng33 added 4 commits March 20, 2026 03:52
Signed-off-by: sfeng33 <4florafeng@gmail.com>
Signed-off-by: sfeng33 <4florafeng@gmail.com>
Signed-off-by: sfeng33 <4florafeng@gmail.com>
Signed-off-by: sfeng33 <4florafeng@gmail.com>
@sfeng33
Copy link
Contributor Author

sfeng33 commented Mar 20, 2026

Rebase to merge conflict

@DarkLight1337 DarkLight1337 enabled auto-merge (squash) March 20, 2026 09:35
@DarkLight1337 DarkLight1337 merged commit b4c1aef into vllm-project:main Mar 20, 2026
42 of 43 checks passed
@github-project-automation github-project-automation bot moved this from Todo to Done in AMD Mar 20, 2026
@sfeng33 sfeng33 deleted the relo-tests branch March 20, 2026 12:20
chooper26 pushed a commit to intellistream/vllm-hust that referenced this pull request Mar 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci/build ready ONLY add when PR is ready to merge/full CI is needed rocm Related to AMD ROCm structured-output v1

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants