[Core][Feat] Add max-waiting-queue-time parameter to reject requests#37413
Open
chaunceyjiang wants to merge 2 commits intovllm-project:mainfrom
Open
[Core][Feat] Add max-waiting-queue-time parameter to reject requests#37413chaunceyjiang wants to merge 2 commits intovllm-project:mainfrom
chaunceyjiang wants to merge 2 commits intovllm-project:mainfrom
Conversation
Signed-off-by: chaunceyjiang <chaunceyjiang@gmail.com>
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a max-waiting-queue-time parameter to reject requests when the server is under high load. This is achieved by tracking the average queue time of recent requests using a new QueueTimeTracker class. The feature is well-integrated, with the new parameter added to EngineArgs and propagated down to the serving layers. The logic to check the queue time and reject requests with a 503 error is implemented in OpenAIServing. The QueueTimeTracker itself uses a sliding window with time-based decay, which is a solid approach. My review found one area for improvement in the QueueTimeTracker implementation regarding an unused variable, which I've commented on.
7 tasks
Signed-off-by: chaunceyjiang <chaunceyjiang@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Add max-waiting-queue-time parameter to reject requests
Test Plan
Test Result
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.