Skip to content

[ROCm][Quantization] fallback trust_remote_code=True in Quark config for some cases #37408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
xuebwang-amd wants to merge 2 commits into from
+33 −6
Closed

[ROCm][Quantization] fallback trust_remote_code=True in Quark config for some cases #37408

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e00b653
main commit
xuebwang-amd Mar 18, 2026
dce059d
emit a warning when this fallback occurs
xuebwang-amd Mar 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 33 additions & 6 deletions vllm/model_executor/layers/quantization/quark/quark.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,12 +64,39 @@ def __init__(
self.dynamic_mxfp4_quant = False

def maybe_update_config(self, model_name: str, revision: str | None = None):
self.hf_config = get_config(
model=model_name,
trust_remote_code=False, # or get from model_config if available
revision=revision,
config_format="auto",
)
try:
self.hf_config = get_config(
model=model_name,
trust_remote_code=False,
revision=revision,
config_format="auto",
)
except (RuntimeError, ValueError) as e:
# Some local quantized checkpoints rely on custom HF config code.
# Retry only for the explicit trust-remote-code failure mode.
error_text = str(e)
if (
"trust_remote_code=True" not in error_text
and "contains custom code which must be executed" not in error_text
and "requires you to execute the configuration file" not in error_text
):
raise

import logging

logger = logging.getLogger(__name__)
logger.warning(
"The model %s requires custom code to be executed. "
"Falling back to `trust_remote_code=True`.",
model_name,
)

self.hf_config = get_config(
model=model_name,
trust_remote_code=True,
Copy link
Copy Markdown
Collaborator

@gshtras gshtras Mar 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

--trust-remote-code needs to be explicitly provided if it is required, doesn't it, to avoid security risks?
Why would you override this silently?

Copy link
Copy Markdown
Contributor Author

@xuebwang-amd xuebwang-amd Mar 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the review! Yes, --trust-remote-code is needed in the CLI.
Please see updated details #37408 (comment).

revision=revision,
config_format="auto",
)
Comment thread
xuebwang-amd marked this conversation as resolved.

quant_config = getattr(self.hf_config, "quantization_config", None)
if quant_config is not None:
Expand Down
Loading