Fix models which use layer_type_validation for Transformers v5#37398
Merged
DarkLight1337 merged 4 commits intovllm-project:mainfrom Mar 18, 2026
Merged
Fix models which use layer_type_validation for Transformers v5#37398DarkLight1337 merged 4 commits intovllm-project:mainfrom
layer_type_validation for Transformers v5#37398DarkLight1337 merged 4 commits intovllm-project:mainfrom
Conversation
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request correctly updates several model configurations to be compatible with breaking changes in transformers v5 by introducing a backward-compatible way to call layer_type_validation. The approach using hasattr is sound.
However, I found a critical issue in vllm/transformers_utils/configs/olmo_hybrid.py where the new validation path for transformers v5 is effectively skipped due to the order of operations, which could lead to model misconfiguration. I've provided a specific comment with a suggested fix for this.
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
DarkLight1337
approved these changes
Mar 18, 2026
github-actions
bot
added
the
ready
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
fxdawnn
pushed a commit
to fxdawnn/vllm
that referenced
this pull request
Mar 19, 2026
…m-project#37398) Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
SouthWest7
pushed a commit
to SouthWest7/vllm
that referenced
this pull request
Mar 27, 2026
…m-project#37398) Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
khairulkabir1661
pushed a commit
to khairulkabir1661/vllm
that referenced
this pull request
Mar 27, 2026
…m-project#37398) Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
Monishver11
pushed a commit
to Monishver11/vllm
that referenced
this pull request
Mar 27, 2026
…m-project#37398) Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com> Signed-off-by: Monishver Chandrasekaran <monishverchandrasekaran@gmail.com>
JiantaoXu
pushed a commit
to JiantaoXu/vllm
that referenced
this pull request
Mar 28, 2026
…m-project#37398) Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
vrdn-23
pushed a commit
to vrdn-23/vllm
that referenced
this pull request
Mar 30, 2026
…m-project#37398) Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com> Signed-off-by: Vinay Damodaran <vrdn@hey.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In huggingface/transformers#41250
transformers.configuration_utils.layer_type_validationwas replaces withPreTrainedConfig.validate_layer_type.This PR updates the vendored configs which used this method to be compatible with both the new and old way of validating layer types.