[BugFix] Use consistent logger everywhere - #3738
Merged
Merged
Conversation
I noticed some files where the centrally-configured logger wasn't being used.
WoosukKwon
approved these changes
Mar 29, 2024
WoosukKwon
left a comment
WoosukKwon
left a comment
Collaborator
There was a problem hiding this comment.
LGTM. Thanks for the fix!
WoosukKwon
enabled auto-merge (squash)
March 29, 2024 22:46
xjpang
pushed a commit
to xjpang/vllm
that referenced
this pull request
Mar 31, 2024
4 tasks
wenhow
pushed a commit
to wenhow/vllm
that referenced
this pull request
Aug 5, 2026
### What this PR does / why we need it? 1. Replace init_routing_v2 with token_permute to optimize performance. Note: This pr will be merged after switching ci to CANN 8.3 ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? vllm bench serve bs = 48 / rr = 10000 / 2k input -> 20k output: before: <img width="489" height="488" alt="image" src="https://github.com/user-attachments/assets/268a19e6-9ab2-47f0-84a1-4f6d3bc342e2" /> after: <img width="480" height="500" alt="image" src="https://github.com/user-attachments/assets/d9b1e628-0520-42d5-8a21-b42f7cd7abc7" /> - vLLM version: v0.11.0 - vLLM main: vllm-project@83f478b Signed-off-by: Pr0Wh1teGivee <calvin_zhu0210@outlook.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed some files where the centrally-configured logger wasn't being used.