[ROCm][CI] Add ROCM_EXTRA_ARGS to audio_in_video test server fixture#37349
Merged
DarkLight1337 merged 1 commit intovllm-project:mainfrom Mar 18, 2026
Merged
Conversation
Signed-off-by: Andreas Karatzas <akaratza@amd.com>
AndreasKaratzas
requested review from
DarkLight1337,
NickLucche,
aarnphm and
robertgshaw2-redhat
as code owners
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request adds ROCM_EXTRA_ARGS to the server fixture in the test_audio_in_video test. This is intended to improve test stability on ROCm platforms by disabling prefix caching and limiting the number of sequences. The changes are correct and effectively apply the necessary arguments for the ROCm environment while having no effect on other platforms. The implementation is clean and uses a shared constant for the ROCm-specific arguments.
DarkLight1337
approved these changes
Mar 18, 2026
github-actions
bot
added
the
ready
wendyliu235
pushed a commit
to wendyliu235/vllm-public
that referenced
this pull request
Mar 18, 2026
…llm-project#37349) Signed-off-by: Andreas Karatzas <akaratza@amd.com>
fxdawnn
pushed a commit
to fxdawnn/vllm
that referenced
this pull request
Mar 19, 2026
…llm-project#37349) Signed-off-by: Andreas Karatzas <akaratza@amd.com>
SouthWest7
pushed a commit
to SouthWest7/vllm
that referenced
this pull request
Mar 27, 2026
…llm-project#37349) Signed-off-by: Andreas Karatzas <akaratza@amd.com>
khairulkabir1661
pushed a commit
to khairulkabir1661/vllm
that referenced
this pull request
Mar 27, 2026
…llm-project#37349) Signed-off-by: Andreas Karatzas <akaratza@amd.com>
Monishver11
pushed a commit
to Monishver11/vllm
that referenced
this pull request
Mar 27, 2026
…llm-project#37349) Signed-off-by: Andreas Karatzas <akaratza@amd.com> Signed-off-by: Monishver Chandrasekaran <monishverchandrasekaran@gmail.com>
JiantaoXu
pushed a commit
to JiantaoXu/vllm
that referenced
this pull request
Mar 28, 2026
…llm-project#37349) Signed-off-by: Andreas Karatzas <akaratza@amd.com>
vrdn-23
pushed a commit
to vrdn-23/vllm
that referenced
this pull request
Mar 30, 2026
…llm-project#37349) Signed-off-by: Andreas Karatzas <akaratza@amd.com> Signed-off-by: Vinay Damodaran <vrdn@hey.com>
EricccYang
pushed a commit
to EricccYang/vllm
that referenced
this pull request
Apr 1, 2026
…llm-project#37349) Signed-off-by: Andreas Karatzas <akaratza@amd.com> Signed-off-by: EricccYang <yangyang4991@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ROCM_EXTRA_ARGSto thetest_audio_in_videoserver fixturestopinstead oflength)Test plan
pytest -s -v tests/entrypoints/openai/chat_completion/test_audio_in_video.pycc @kenroche