Skip to content

Fix Phi3 test that fails with Transformers v5 #37298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hmellor merged 1 commit into from
Mar 17, 2026
Merged

Fix Phi3 test that fails with Transformers v5 #37298

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions tests/models/multimodal/pooling/test_phi3v.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@

import pytest
import torch.nn.functional as F
import transformers.utils
from PIL import Image

from vllm.assets.base import get_vllm_public_assets
Expand All @@ -12,6 +13,12 @@
from ....utils import large_gpu_test
from ...utils import check_embeddings_close

# BC for method that was deleted in Transformers v5.
# Only needed for generating the HF reference.
transformers.utils.is_flash_attn_greater_or_equal_2_10 = (
lambda: transformers.utils.is_flash_attn_greater_or_equal("2.1.0")
)
Comment thread
hmellor marked this conversation as resolved.

HF_TEXT_PROMPTS = [
# T -> X
"Find me an everyday image that matches the given caption: The label of the object is stop sign", # noqa: E501
Expand Down
Loading