[Chore] Replace all base64 usages with faster pybase64 package#37290
Merged
DarkLight1337 merged 4 commits intovllm-project:mainfrom Mar 17, 2026
Merged
[Chore] Replace all base64 usages with faster pybase64 package#37290DarkLight1337 merged 4 commits intovllm-project:mainfrom
DarkLight1337 merged 4 commits intovllm-project:mainfrom
Conversation
|
Documentation preview: https://vllm--37290.org.readthedocs.build/en/37290/ |
noooop
approved these changes
Mar 17, 2026
Contributor
There was a problem hiding this comment.
Code Review
This pull request replaces all usages of the standard base64 library with the faster pybase64 package. The changes are mostly correct and also include an update to the pre-commit hook to enforce this change. However, I found one critical issue in vllm/multimodal/media/audio.py where pybase64 is used without being imported, which will cause a NameError.
DarkLight1337
approved these changes
Mar 17, 2026
hmellor
approved these changes
Mar 17, 2026
|
Hi @Isotr0py, the pre-commit checks have failed. Please run: uv pip install pre-commit>=4.5.1
pre-commit install
pre-commit run --all-filesThen, commit the changes and push to your branch. For future commits, Tip Is
|
Signed-off-by: Isotr0py <mozf@mail2.sysu.edu.cn>
Lucaskabela
pushed a commit
to Lucaskabela/vllm
that referenced
this pull request
Mar 17, 2026
…project#37290) Signed-off-by: Isotr0py <mozf@mail2.sysu.edu.cn>
andylolu2
pushed a commit
to andylolu2/vllm
that referenced
this pull request
Mar 18, 2026
…project#37290) Signed-off-by: Isotr0py <mozf@mail2.sysu.edu.cn>
wendyliu235
pushed a commit
to wendyliu235/vllm-public
that referenced
this pull request
Mar 18, 2026
…project#37290) Signed-off-by: Isotr0py <mozf@mail2.sysu.edu.cn>
fxdawnn
pushed a commit
to fxdawnn/vllm
that referenced
this pull request
Mar 19, 2026
…project#37290) Signed-off-by: Isotr0py <mozf@mail2.sysu.edu.cn>
khairulkabir1661
pushed a commit
to khairulkabir1661/vllm
that referenced
this pull request
Mar 27, 2026
…project#37290) Signed-off-by: Isotr0py <mozf@mail2.sysu.edu.cn>
Monishver11
pushed a commit
to Monishver11/vllm
that referenced
this pull request
Mar 27, 2026
…project#37290) Signed-off-by: Isotr0py <mozf@mail2.sysu.edu.cn> Signed-off-by: Monishver Chandrasekaran <monishverchandrasekaran@gmail.com>
JiantaoXu
pushed a commit
to JiantaoXu/vllm
that referenced
this pull request
Mar 28, 2026
…project#37290) Signed-off-by: Isotr0py <mozf@mail2.sysu.edu.cn>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
pybase64, there're still lots of legacy/new functions still usebase64.base64usage withpybase64and addsbase64tocheck_forbidden_imports.pysimilar toregex.Test Plan
Test Result
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.