Skip to content

[Bugfix] Standardize custom HF Processor init#37289

Merged
DarkLight1337 merged 2 commits intovllm-project:mainfrom
DarkLight1337:fix-param-order
Mar 17, 2026
Merged

[Bugfix] Standardize custom HF Processor init#37289
DarkLight1337 merged 2 commits intovllm-project:mainfrom
DarkLight1337:fix-param-order

Conversation

@DarkLight1337
Copy link
Copy Markdown
Member

@DarkLight1337 DarkLight1337 commented Mar 17, 2026

Purpose

  • Per-request kwargs should override config kwargs when initializing the HF processor.
  • Initialize image processor outside of HF processor constructor for GLM4V and Qwen-VL, so that the initializer's signature follows standard HF conventions.

Test Plan

Test Result


Essential Elements of an Effective PR Description Checklist
  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.
  • (Optional) Release notes update. If your change is user facing, please update the release notes draft in the Google Doc.

Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
@DarkLight1337 DarkLight1337 requested a review from Isotr0py March 17, 2026 10:54
@DarkLight1337 DarkLight1337 added the ready ONLY add when PR is ready to merge/full CI is needed label Mar 17, 2026
@DarkLight1337 DarkLight1337 requested a review from hmellor March 17, 2026 10:55
@mergify mergify bot added deepseek Related to DeepSeek models qwen Related to Qwen models bug Something isn't working labels Mar 17, 2026
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request standardizes the initialization of custom Hugging Face processors, focusing on how per-request keyword arguments override default configurations. The changes correctly adjust dictionary unpacking to prioritize user-provided arguments. Additionally, the initialization of image processors for GLM4V and Qwen-VL models is refactored into dedicated factory methods, which simplifies the main processor's constructor and improves code clarity. The implementation is sound and aligns with the stated goals.

@DarkLight1337 DarkLight1337 enabled auto-merge (squash) March 17, 2026 11:04
@mergify
Copy link
Copy Markdown

mergify bot commented Mar 17, 2026

Hi @DarkLight1337, the pre-commit checks have failed. Please run:

uv pip install pre-commit>=4.5.1
pre-commit install
pre-commit run --all-files

Then, commit the changes and push to your branch.

For future commits, pre-commit will run automatically on changed files before each commit.

Tip

Is mypy failing?
mypy is run differently in CI. If the failure is related to this check, please use the following command to run it locally:
# For mypy (substitute "3.10" with the failing version if needed)
pre-commit run --hook-stage manual mypy-3.10

Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
@DarkLight1337 DarkLight1337 requested a review from njhill as a code owner March 17, 2026 13:53
@DarkLight1337 DarkLight1337 merged commit c781fbb into vllm-project:main Mar 17, 2026
54 checks passed
@DarkLight1337 DarkLight1337 deleted the fix-param-order branch March 17, 2026 15:38
Lucaskabela pushed a commit to Lucaskabela/vllm that referenced this pull request Mar 17, 2026
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
wendyliu235 pushed a commit to wendyliu235/vllm-public that referenced this pull request Mar 18, 2026
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
fxdawnn pushed a commit to fxdawnn/vllm that referenced this pull request Mar 19, 2026
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
SouthWest7 pushed a commit to SouthWest7/vllm that referenced this pull request Mar 27, 2026
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
khairulkabir1661 pushed a commit to khairulkabir1661/vllm that referenced this pull request Mar 27, 2026
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
Monishver11 pushed a commit to Monishver11/vllm that referenced this pull request Mar 27, 2026
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
Signed-off-by: Monishver Chandrasekaran <monishverchandrasekaran@gmail.com>
JiantaoXu pushed a commit to JiantaoXu/vllm that referenced this pull request Mar 28, 2026
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
vrdn-23 pushed a commit to vrdn-23/vllm that referenced this pull request Mar 30, 2026
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
Signed-off-by: Vinay Damodaran <vrdn@hey.com>
EricccYang pushed a commit to EricccYang/vllm that referenced this pull request Apr 1, 2026
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
Signed-off-by: EricccYang <yangyang4991@gmail.com>
liuchenbing2026 pushed a commit to liuchenbing2026/vllm that referenced this pull request Apr 4, 2026
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working deepseek Related to DeepSeek models qwen Related to Qwen models ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants