-
-
Notifications
You must be signed in to change notification settings - Fork 16.4k
[Bugfix] Fix for builtins (forward fix of pytorch/177558) #37234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
zou3519
merged 5 commits into
vllm-project:main
from
Lucaskabela:lucaskabela/monkeypatch_aot_compile_fix
Mar 31, 2026
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
160e4da
Fix for builtins (forward fix of pytorch/177558)
Lucaskabela b83d29c
Merge branch 'main' into lucaskabela/monkeypatch_aot_compile_fix
Lucaskabela fd85ae1
Merge branch 'main' into lucaskabela/monkeypatch_aot_compile_fix
Lucaskabela 513e9c8
Merge branch 'main' into lucaskabela/monkeypatch_aot_compile_fix
Lucaskabela 5098a99
Merge branch 'main' into lucaskabela/monkeypatch_aot_compile_fix
Lucaskabela File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do you have a test that would exercise this? Otherwise we may just silently break it in the 2.12 update
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is in @hmellor's PR which surfaced the need for this monkeypatch
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tests/compile/fullgraph/test_multimodal_compile.py test with transformers backend fails without this PR's patch
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like we have a bit of a stalemate, could we merge this first then I'll be using it in #30518?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yup let's do it