Skip to content

Fix EagleMistralLarge3Model initialization #37232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ywang96 merged 1 commit into from
Mar 16, 2026
Merged

Fix EagleMistralLarge3Model initialization #37232

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions vllm/model_executor/models/mistral_large_3_eagle.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,7 @@ def __init__(
prefix=maybe_prefix(prefix, "fc"),
)
self.norm = RMSNorm(config.hidden_size, eps=config.rms_norm_eps)
self.aux_hidden_state_layers: tuple[int, ...] = ()

@gemini-code-assist gemini-code-assist Bot Mar 16, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

While this change correctly initializes aux_hidden_state_layers, it highlights a broader maintainability issue. The __init__ method of EagleMistralLarge3Model does not call super().__init__() from its base class DeepseekV2Model, but instead re-implements much of its logic. This is why aux_hidden_state_layers had to be added here manually after it was added to the base class.

To prevent similar issues in the future and to track this technical debt, I suggest adding a TODO comment. This will make it clear that a refactoring is needed to make the class more robust against changes in its parent.

        # TODO: Refactor to call super().__init__ from DeepseekV2Model
        # to avoid missing future attributes.
        self.aux_hidden_state_layers: tuple[int, ...] = ()

self.make_empty_intermediate_tensors = make_empty_intermediate_tensors_factory(
["hidden_states", "residual"], config.hidden_size
)
Expand Down
Loading