[Bugfix] Make siglip/clip compatible with transformers v5 #37200
Merged
hmellor merged 1 commit intovllm-project:mainfrom Mar 16, 2026
Merged
[Bugfix] Make siglip/clip compatible with transformers v5 #37200hmellor merged 1 commit intovllm-project:mainfrom
hmellor merged 1 commit intovllm-project:mainfrom
Conversation
mergify
bot
added
multi-modality
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request addresses a compatibility issue with transformers v5 in the siglip and clip model tests. The changes adapt the tests to handle the new BaseModelOutputWithPooling return type from feature extraction methods. My review includes suggestions to make the implementation more concise and idiomatic by using getattr for accessing the pooler_output, which simplifies the logic for handling different transformers versions.
Comment on lines
+61
to
+62
| if not isinstance(pooled_output, torch.Tensor): | ||
| pooled_output = pooled_output.pooler_output |
Contributor
There was a problem hiding this comment.
For better readability and conciseness, you can use getattr to handle both cases (tensor output from older transformers versions and BaseModelOutputWithPooling from newer versions). This avoids the explicit type check and makes the intent clearer.
pooled_output = getattr(pooled_output, 'pooler_output', pooled_output)
Comment on lines
+78
to
+79
| if not isinstance(pooled_output, torch.Tensor): | ||
| pooled_output = pooled_output.pooler_output |
Contributor
There was a problem hiding this comment.
Similar to the comment on test_clip.py, using getattr here would make the code more concise and idiomatic for handling different return types.
pooled_output = getattr(pooled_output, 'pooler_output', pooled_output)
github-actions
bot
added
the
ready
Lucaskabela
pushed a commit
to Lucaskabela/vllm
that referenced
this pull request
Mar 17, 2026
…ct#37200) Signed-off-by: raushan <raushan@huggingface.co>
wendyliu235
pushed a commit
to wendyliu235/vllm-public
that referenced
this pull request
Mar 18, 2026
…ct#37200) Signed-off-by: raushan <raushan@huggingface.co>
fxdawnn
pushed a commit
to fxdawnn/vllm
that referenced
this pull request
Mar 19, 2026
…ct#37200) Signed-off-by: raushan <raushan@huggingface.co>
khairulkabir1661
pushed a commit
to khairulkabir1661/vllm
that referenced
this pull request
Mar 27, 2026
…ct#37200) Signed-off-by: raushan <raushan@huggingface.co>
Monishver11
pushed a commit
to Monishver11/vllm
that referenced
this pull request
Mar 27, 2026
…ct#37200) Signed-off-by: raushan <raushan@huggingface.co> Signed-off-by: Monishver Chandrasekaran <monishverchandrasekaran@gmail.com>
JiantaoXu
pushed a commit
to JiantaoXu/vllm
that referenced
this pull request
Mar 28, 2026
…ct#37200) Signed-off-by: raushan <raushan@huggingface.co>
vrdn-23
pushed a commit
to vrdn-23/vllm
that referenced
this pull request
Mar 30, 2026
…ct#37200) Signed-off-by: raushan <raushan@huggingface.co> Signed-off-by: Vinay Damodaran <vrdn@hey.com>
EricccYang
pushed a commit
to EricccYang/vllm
that referenced
this pull request
Apr 1, 2026
…ct#37200) Signed-off-by: raushan <raushan@huggingface.co> Signed-off-by: EricccYang <yangyang4991@gmail.com>
liuchenbing2026
pushed a commit
to liuchenbing2026/vllm
that referenced
this pull request
Apr 4, 2026
…ct#37200) Signed-off-by: raushan <raushan@huggingface.co>
big-yellow-duck
pushed a commit
to EmbeddedLLM/vllm
that referenced
this pull request
Apr 8, 2026
…ct#37200) Signed-off-by: raushan <raushan@huggingface.co>
mtparet
pushed a commit
to blackfuel-ai/vllm
that referenced
this pull request
Apr 9, 2026
…ct#37200) Signed-off-by: raushan <raushan@huggingface.co>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From v5 we are returning a
BaseModelOutputWithPoolingfromget_xxx_features. This PR fixes the test to be compatible with v4-format tensor output and v5-format dict outputcc @hmellor