[Bugfix] Avoid LD_PRELOAD check on MacOS#37145
Merged
vllm-bot merged 1 commit intovllm-project:mainfrom Mar 16, 2026
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request addresses a runtime error on macOS related to an LD_PRELOAD check. The change correctly restricts this check to Linux systems by using sys.platform.startswith("linux"), which resolves the issue. The implementation is straightforward and effective. I have no further comments as the change is correct and follows existing patterns in the codebase.
Member
Author
|
Hi @DarkLight1337 Could you please help to check this? Thank you :) |
DarkLight1337
approved these changes
Mar 16, 2026
Lucaskabela
pushed a commit
to Lucaskabela/vllm
that referenced
this pull request
Mar 17, 2026
Signed-off-by: jiang1.li <jiang1.li@intel.com>
wendyliu235
pushed a commit
to wendyliu235/vllm-public
that referenced
this pull request
Mar 18, 2026
Signed-off-by: jiang1.li <jiang1.li@intel.com>
fxdawnn
pushed a commit
to fxdawnn/vllm
that referenced
this pull request
Mar 19, 2026
Signed-off-by: jiang1.li <jiang1.li@intel.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Test Plan
Test Result
Fixed
https://github.com/bigPYJ1151/vllm/actions/runs/23130147500/job/67181633865#logs
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.