[responsesAPI][ez] add a unit test for SimpleContext logprobs#37126
Merged
houseroad merged 2 commits intovllm-project:mainfrom Mar 16, 2026
Merged
[responsesAPI][ez] add a unit test for SimpleContext logprobs#37126houseroad merged 2 commits intovllm-project:mainfrom
houseroad merged 2 commits intovllm-project:mainfrom
Conversation
Signed-off-by: Andrew Xia <axia@meta.com>
Contributor
There was a problem hiding this comment.
Code Review
This pull request adds a unit test for streaming logprobs in the responses API. The test verifies that when logprobs are requested, the streaming events contain the correct logprob data structure. My review focuses on strengthening this new test to ensure it fully validates the expected behavior. I've suggested an improvement to assert that top_logprobs are not just present but also contain data, which makes the test more robust.
Signed-off-by: Andrew Xia <axia@meta.com>
Contributor
Author
|
cc @chaunceyjiang / @houseroad could I get a quick review here? |
Lucaskabela
pushed a commit
to Lucaskabela/vllm
that referenced
this pull request
Mar 17, 2026
…roject#37126) Signed-off-by: Andrew Xia <axia@meta.com>
wendyliu235
pushed a commit
to wendyliu235/vllm-public
that referenced
this pull request
Mar 18, 2026
…roject#37126) Signed-off-by: Andrew Xia <axia@meta.com>
fxdawnn
pushed a commit
to fxdawnn/vllm
that referenced
this pull request
Mar 19, 2026
…roject#37126) Signed-off-by: Andrew Xia <axia@meta.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
this adds a unit test to make sure logprobs are outputted correctly, as it would look like this in streaming. no behavioral changes. Adding so I can be more confident in the migration in #37007.
Test Plan
unit test passes
python -m pytest tests/entrypoints/openai/responses/test_simple.py::test_streaming_logprobs