[Frontend] Reduce chat template warmup logging levels#37062
Merged
njhill merged 2 commits intovllm-project:mainfrom Mar 14, 2026
Merged
[Frontend] Reduce chat template warmup logging levels#37062njhill merged 2 commits intovllm-project:mainfrom
njhill merged 2 commits intovllm-project:mainfrom
Conversation
Not important messages for default case. Exception shouldn't be logged as error unless it's really an error in which case it should be fatal. Signed-off-by: Nick Hill <nickhill123@gmail.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request reduces the logging level for chat template warmup messages. INFO-level logs are changed to DEBUG, and exception logging is changed from ERROR to WARNING. This change is incomplete as a similar logging call for multi-modal warmup failures remains at the ERROR level, which could lead to misleading alerts. I've added a comment suggesting to make the logging consistent for all warmup failures.
5 tasks
Isotr0py
approved these changes
Mar 14, 2026
Signed-off-by: Nick Hill <nickhill123@gmail.com>
athrael-soju
pushed a commit
to athrael-soju/vllm
that referenced
this pull request
Mar 16, 2026
…7062) Signed-off-by: Nick Hill <nickhill123@gmail.com> Signed-off-by: Athrael Soju <athrael.soju@gmail.com>
Lucaskabela
pushed a commit
to Lucaskabela/vllm
that referenced
this pull request
Mar 17, 2026
…7062) Signed-off-by: Nick Hill <nickhill123@gmail.com>
wendyliu235
pushed a commit
to wendyliu235/vllm-public
that referenced
this pull request
Mar 18, 2026
…7062) Signed-off-by: Nick Hill <nickhill123@gmail.com>
fxdawnn
pushed a commit
to fxdawnn/vllm
that referenced
this pull request
Mar 19, 2026
…7062) Signed-off-by: Nick Hill <nickhill123@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not important messages for default case.
Exception shouldn't be logged as error unless it's really an error in which case it should be fatal.