Fix pipeline parallel with multimodal models with the Transformers modelling backend#37057
Merged
DarkLight1337 merged 1 commit intovllm-project:mainfrom Mar 16, 2026
Merged
Conversation
…delling backend Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces two main improvements. First, it adds support for pipeline parallelism in multimodal models by using attrgetter and a new attrsetter helper to handle nested modules, which is a clean and effective solution. Second, it refactors the logic for checking tie_word_embeddings to support both Transformers v4 and v5 configurations, centralizing this logic in a new _get_tie_word_embeddings method. The changes are well-implemented, correctly address the described issues, and improve the overall robustness and feature set of the Transformers modeling backend. The code is clear and the approach is solid.
DarkLight1337
approved these changes
Mar 16, 2026
Lucaskabela
pushed a commit
to Lucaskabela/vllm
that referenced
this pull request
Mar 17, 2026
…delling backend (vllm-project#37057) Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
wendyliu235
pushed a commit
to wendyliu235/vllm-public
that referenced
this pull request
Mar 18, 2026
…delling backend (vllm-project#37057) Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
fxdawnn
pushed a commit
to fxdawnn/vllm
that referenced
this pull request
Mar 19, 2026
…delling backend (vllm-project#37057) Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
khairulkabir1661
pushed a commit
to khairulkabir1661/vllm
that referenced
this pull request
Mar 27, 2026
…delling backend (vllm-project#37057) Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
Monishver11
pushed a commit
to Monishver11/vllm
that referenced
this pull request
Mar 27, 2026
…delling backend (vllm-project#37057) Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com> Signed-off-by: Monishver Chandrasekaran <monishverchandrasekaran@gmail.com>
JiantaoXu
pushed a commit
to JiantaoXu/vllm
that referenced
this pull request
Mar 28, 2026
…delling backend (vllm-project#37057) Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
vrdn-23
pushed a commit
to vrdn-23/vllm
that referenced
this pull request
Mar 30, 2026
…delling backend (vllm-project#37057) Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com> Signed-off-by: Vinay Damodaran <vrdn@hey.com>
EricccYang
pushed a commit
to EricccYang/vllm
that referenced
this pull request
Apr 1, 2026
…delling backend (vllm-project#37057) Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com> Signed-off-by: EricccYang <yangyang4991@gmail.com>
liuchenbing2026
pushed a commit
to liuchenbing2026/vllm
that referenced
this pull request
Apr 4, 2026
…delling backend (vllm-project#37057) Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
big-yellow-duck
pushed a commit
to EmbeddedLLM/vllm
that referenced
this pull request
Apr 8, 2026
…delling backend (vllm-project#37057) Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
mtparet
pushed a commit
to blackfuel-ai/vllm
that referenced
this pull request
Apr 9, 2026
…delling backend (vllm-project#37057) Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In Transformers v4
tie_word_embeddingsis found in the text model config, but in v5 it's found in the top level config. The Transformers modelling backend now checks both places.Base.pipeline_parallelwas not able to apply the pipeline parallel plan to multimodal models because the plan referred to nested modules (text_model.layersfor example). This Transformers modelling backend now usesattrgetter(and a custom inverseattrsetter) to make sure that nested modules can still be accessed.