Fix text only inputs for MRoPE models with the Transformers modelling backend#37055
Merged
DarkLight1337 merged 1 commit intovllm-project:mainfrom Mar 16, 2026
Merged
Conversation
… backend Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request correctly addresses a failure for text-only prompts in MRoPE models by ensuring mm_token_type_ids is always passed to the model's get_rope_index method. When no multimodal data is present, a zero tensor is now created. I have one suggestion to improve the implementation by using the correct dtype for this tensor to avoid potential mismatches.
hmellor
force-pushed
the
fix-mrope-text-only
branch
from
7cf9809 to
fa77ffe
Compare
DarkLight1337
approved these changes
Mar 16, 2026
github-actions
bot
added
the
ready
Lucaskabela
pushed a commit
to Lucaskabela/vllm
that referenced
this pull request
Mar 17, 2026
… backend (vllm-project#37055) Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
wendyliu235
pushed a commit
to wendyliu235/vllm-public
that referenced
this pull request
Mar 18, 2026
… backend (vllm-project#37055) Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
khairulkabir1661
pushed a commit
to khairulkabir1661/vllm
that referenced
this pull request
Mar 27, 2026
… backend (vllm-project#37055) Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
JiantaoXu
pushed a commit
to JiantaoXu/vllm
that referenced
this pull request
Mar 28, 2026
… backend (vllm-project#37055) Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
mtparet
pushed a commit
to blackfuel-ai/vllm
that referenced
this pull request
Apr 9, 2026
… backend (vllm-project#37055) Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In Transformers v5 text only prompts would fail because
mm_token_type_idsis a required positional arg and vLLM was only passing it if there was image data present.Now, in the Transformers modelling backend, if there is no image data we pass
mm_token_type_idsto indicate that all the data is text.