Skip to content

[bug] Fix deadlock with pause resume and collective_rpc #37024

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
robertgshaw2-redhat merged 2 commits into from
Mar 19, 2026
+5 −1
Merged

[bug] Fix deadlock with pause resume and collective_rpc #37024

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2913b0b
x
hao-aaron Mar 14, 2026
8c37e97
x
hao-aaron Mar 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion vllm/v1/engine/core.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1632,7 +1632,11 @@ def add_request(self, request: Request, request_wave: int = 0):
if self.has_coordinator and request_wave != self.current_wave:
if request_wave > self.current_wave:
self.current_wave = request_wave
elif not self.engines_running:
elif (
not self.engines_running
and self.scheduler.pause_state == PauseState.UNPAUSED
):
self.engines_running = True
# Request received for an already-completed wave, notify
# front-end that we need to start the next one.
self.output_queue.put_nowait(
Expand Down
Loading