[BugFix] Fix "DP Coordinator receives unexpected..." messages#37008
Merged
robertgshaw2-redhat merged 1 commit intovllm-project:mainfrom Mar 13, 2026
Merged
[BugFix] Fix "DP Coordinator receives unexpected..." messages#37008robertgshaw2-redhat merged 1 commit intovllm-project:mainfrom
robertgshaw2-redhat merged 1 commit intovllm-project:mainfrom
Conversation
Signed-off-by: Nick Hill <nickhill123@gmail.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request addresses an issue where the DP Coordinator logs an error upon receiving expected ZMQ unsubscribe messages from engines during shutdown. The change correctly modifies the condition to ignore these b"\x00" messages, thus preventing spurious error logs. The fix is correct and aligns with the expected behavior of ZMQ sockets. I have no further suggestions.
robertgshaw2-redhat
approved these changes
Mar 13, 2026
athrael-soju
pushed a commit
to athrael-soju/vllm
that referenced
this pull request
Mar 15, 2026
…roject#37008) Signed-off-by: Nick Hill <nickhill123@gmail.com> Signed-off-by: Athrael Soju <athrael.soju@gmail.com>
athrael-soju
pushed a commit
to athrael-soju/vllm
that referenced
this pull request
Mar 16, 2026
…roject#37008) Signed-off-by: Nick Hill <nickhill123@gmail.com> Signed-off-by: Athrael Soju <athrael.soju@gmail.com>
Lucaskabela
pushed a commit
to Lucaskabela/vllm
that referenced
this pull request
Mar 17, 2026
…roject#37008) Signed-off-by: Nick Hill <nickhill123@gmail.com>
wendyliu235
pushed a commit
to wendyliu235/vllm-public
that referenced
this pull request
Mar 18, 2026
…roject#37008) Signed-off-by: Nick Hill <nickhill123@gmail.com>
fxdawnn
pushed a commit
to fxdawnn/vllm
that referenced
this pull request
Mar 19, 2026
…roject#37008) Signed-off-by: Nick Hill <nickhill123@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This error is sometimes logged during shutdown, it is because of pub/sub socket unsubscribe messages, which are expected:
Introduced by #34861