[Bugfix][LoRA] Fix Qwen35 LoRA#36976
Merged
DarkLight1337 merged 12 commits intovllm-project:mainfrom Mar 20, 2026
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request aims to fix LoRA support for Qwen3.5 models. The main change is to split the fused in_proj_qkvz layer into separate in_proj_qkv and in_proj_z layers when LoRA is enabled. This required modifications to layer initialization, the forward pass, weight loading, and the packed_modules_mapping for LoRA. While the overall approach is sound, I've identified a critical issue in Qwen3_5ForConditionalGeneration where the packed_modules_mapping is not correctly initialized, which would likely prevent LoRA from working correctly for that model. I have provided a specific code suggestion to address this.
musab-mk
approved these changes
Mar 14, 2026
musab-mk
left a comment
musab-mk
left a comment
There was a problem hiding this comment.
I tested this PR and I can confirm that this fixes the IndexError in _capture_cudagraphs for LoRA adapter on Qwen/Qwen3.5-397B-A17B-FP8 as a base.
Signed-off-by: Jee Jee Li <pandaleefree@gmail.com>
Signed-off-by: Jee Jee Li <pandaleefree@gmail.com>
8 tasks
5 tasks
This was referenced Mar 16, 2026
Contributor
|
@jeejeelee I think we can proceed with merging in this fix thanks! |
|
@dcmaddix I think we are waiting for @sighingnow to approve |
|
This pull request has merge conflicts that must be resolved before it can be |
8 tasks
Signed-off-by: Jee Jee Li <pandaleefree@gmail.com>
Signed-off-by: Jee Jee Li <pandaleefree@gmail.com>
jeejeelee
force-pushed
the
fix-qwen35-lora
branch
from
0dcdf60 to
1a1c491
Compare
|
This pull request has merge conflicts that must be resolved before it can be |
DarkLight1337
approved these changes
Mar 20, 2026
Contributor
|
Will this PR be included in v0.18? Installing vLLM from source is somewhat cumbersome |
Member
|
No, we have cut the branch for v0.18 a few days ago already |
Contributor
|
Got it. Thanks anyway |
chooper26
pushed a commit
to intellistream/vllm-hust
that referenced
this pull request
Mar 21, 2026
Signed-off-by: Jee Jee Li <pandaleefree@gmail.com>
1 task
|
I tried building from source with but the build does not complete successfully: `ptxas /tmp/tmpxft_00000521_00000000-6_sm89_kernel_fe4m3fn_u4_bfloat16.ptx, line 279629; error : Unexpected instruction types specified for 'mma'
|
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Test Plan
Test Result
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.