[Bugfix][Spec Decode] Avoid double call of Ngram CPU#36952
Merged
benchislett merged 1 commit intovllm-project:mainfrom Mar 13, 2026
Merged
[Bugfix][Spec Decode] Avoid double call of Ngram CPU#36952benchislett merged 1 commit intovllm-project:mainfrom
benchislett merged 1 commit intovllm-project:mainfrom
Conversation
ekagra-ranjan
changed the title
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request correctly removes a redundant call to self.drafter.propose within the propose_draft_token_ids method. This was causing the n-gram proposal logic to execute twice for the CPU-based NgramProposer. The removal of the duplicate code block resolves this performance issue. The fix is clean and accurate.
benchislett
approved these changes
Mar 13, 2026
wendyliu235
pushed a commit
to wendyliu235/vllm-public
that referenced
this pull request
Mar 18, 2026
khairulkabir1661
pushed a commit
to khairulkabir1661/vllm
that referenced
this pull request
Mar 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After this PR #29184, ngram CPU was being called twice