Skip to content

[Tests] Shutdown test RemoteVLLMServer cleanly #36950

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
markmc merged 1 commit into from
Mar 13, 2026
Merged

[Tests] Shutdown test RemoteVLLMServer cleanly #36950

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 3 additions & 6 deletions tests/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -235,13 +235,10 @@ def __exit__(self, exc_type, exc_value, traceback):
except (ProcessLookupError, OSError):
pgid = None

# Phase 1: graceful SIGTERM to the entire process group
if pgid is not None:
with contextlib.suppress(ProcessLookupError, OSError):
os.killpg(pgid, signal.SIGTERM)
print(f"[RemoteOpenAIServer] Sent SIGTERM to process group {pgid}")
else:
# Phase 1: graceful SIGTERM to the root process
with contextlib.suppress(ProcessLookupError, OSError):
self.proc.terminate()
print(f"[RemoteOpenAIServer] Sent SIGTERM to process {pid}")

try:
self.proc.wait(timeout=15)
Expand Down
Loading