[LoRA][BugFix] Fix skipped LoRA adapters for Mistral3#36928
Merged
robertgshaw2-redhat merged 3 commits intomainfrom Mar 18, 2026
Merged
[LoRA][BugFix] Fix skipped LoRA adapters for Mistral3#36928robertgshaw2-redhat merged 3 commits intomainfrom
robertgshaw2-redhat merged 3 commits intomainfrom
Conversation
Signed-off-by: Woosuk Kwon <woosuk@inferact.ai>
Contributor
There was a problem hiding this comment.
Code Review
The code changes introduce a new prefix mapping in the hf_to_vllm_mapper for the Mistral3 model. This mapping, "model.": "language_model.model.", is intended to correctly handle PEFT LoRA weights that might use a model. prefix, ensuring compatibility with the vllm's internal language_model.model. structure.
robertgshaw2-redhat
approved these changes
Mar 12, 2026
Collaborator
|
Thank you |
njhill
reviewed
Mar 14, 2026
Comment on lines
+421
to
+423
| # Some PEFT LoRAs are trained against the text submodule directly | ||
| # and produce names like `base_model.model.model.layers.*`. | ||
| "model.": "language_model.model.", |
Member
There was a problem hiding this comment.
@WoosukKwon I think the test is failing because this is taking precedence over the other mappings.
Probably this just needs to be moved below the others.
Signed-off-by: Nick Hill <nickhill123@gmail.com>
ikaadil
pushed a commit
to ikaadil/vllm
that referenced
this pull request
Mar 19, 2026
…6928) Signed-off-by: Woosuk Kwon <woosuk@inferact.ai> Signed-off-by: Ifta Khairul Alam Adil <ikaadil007@gmail.com>
ikaadil
pushed a commit
to ikaadil/vllm
that referenced
this pull request
Mar 19, 2026
…6928) Signed-off-by: Woosuk Kwon <woosuk@inferact.ai> Signed-off-by: Ifta Khairul Alam Adil <ikaadil007@gmail.com>
fxdawnn
pushed a commit
to fxdawnn/vllm
that referenced
this pull request
Mar 19, 2026
…6928) Signed-off-by: Woosuk Kwon <woosuk@inferact.ai>
SouthWest7
pushed a commit
to SouthWest7/vllm
that referenced
this pull request
Mar 27, 2026
…6928) Signed-off-by: Woosuk Kwon <woosuk@inferact.ai>
khairulkabir1661
pushed a commit
to khairulkabir1661/vllm
that referenced
this pull request
Mar 27, 2026
…6928) Signed-off-by: Woosuk Kwon <woosuk@inferact.ai>
Monishver11
pushed a commit
to Monishver11/vllm
that referenced
this pull request
Mar 27, 2026
…6928) Signed-off-by: Woosuk Kwon <woosuk@inferact.ai> Signed-off-by: Monishver Chandrasekaran <monishverchandrasekaran@gmail.com>
JiantaoXu
pushed a commit
to JiantaoXu/vllm
that referenced
this pull request
Mar 28, 2026
…6928) Signed-off-by: Woosuk Kwon <woosuk@inferact.ai>
vrdn-23
pushed a commit
to vrdn-23/vllm
that referenced
this pull request
Mar 30, 2026
…6928) Signed-off-by: Woosuk Kwon <woosuk@inferact.ai> Signed-off-by: Vinay Damodaran <vrdn@hey.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, there is a bug with Mistral3 models that some LoRA adapters are skipped and the model produces identical results with and without LoRA. This PR fixes the bug by bringing the skipped one.