Skip to content

[Bugfix] fix main branch pre-commit error (1 line change)#36897

Merged
vllm-bot merged 1 commit intovllm-project:mainfrom
SoluMilken:fix-pre-commit-error
Mar 12, 2026
Merged

[Bugfix] fix main branch pre-commit error (1 line change)#36897
vllm-bot merged 1 commit intovllm-project:mainfrom
SoluMilken:fix-pre-commit-error

Conversation

@SoluMilken
Copy link
Contributor

@SoluMilken SoluMilken commented Mar 12, 2026

Purpose

⚠️ Main branch got pre-commit CI workflow error!!!! ⚠️
https://github.com/vllm-project/vllm/actions/runs/23009533389/job/66815794167

image

Test Plan

pre-commit run --show-diff-on-failure --color=always --all-files --hook-stage manual

Test Result

https://github.com/vllm-project/vllm/actions/runs/23010892261/job/66820778095?pr=36897
image


Essential Elements of an Effective PR Description Checklist
  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.
  • (Optional) Release notes update. If your change is user facing, please update the release notes draft in the Google Doc.

@SoluMilken SoluMilken changed the title fix pre-commit error [CI] fix pre-commit error Mar 12, 2026
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request aims to fix a pre-commit error by changing the skip condition in a test. However, the proposed change from a CUDA-specific check to a generic accelerator check introduces a potential issue. The test itself remains CUDA-specific, which will cause it to fail on systems with non-CUDA accelerators. My review provides a correction to use the idiomatic torch.cuda.is_available() for the skip condition, aligning it with the test's implementation.

@SoluMilken SoluMilken force-pushed the fix-pre-commit-error branch from 02c8782 to bb4fbba Compare March 12, 2026 15:47
@SoluMilken SoluMilken marked this pull request as ready for review March 12, 2026 15:47
@SoluMilken SoluMilken marked this pull request as draft March 12, 2026 15:50
Signed-off-by: SoluMilken <ypiheyn.imm02g@g2.nctu.edu.tw>
@SoluMilken SoluMilken force-pushed the fix-pre-commit-error branch from bb4fbba to 38c447d Compare March 12, 2026 15:51
@SoluMilken SoluMilken changed the title [CI] fix pre-commit error [CI] fix main branch pre-commit workflow error Mar 12, 2026
@SoluMilken SoluMilken changed the title [CI] fix main branch pre-commit workflow error [Bugfix] fix main branch pre-commit workflow error Mar 12, 2026
@SoluMilken SoluMilken marked this pull request as ready for review March 12, 2026 15:53
@mergify mergify bot added the bug Something isn't working label Mar 12, 2026
@SoluMilken SoluMilken changed the title [Bugfix] fix main branch pre-commit workflow error [Bugfix] fix main branch pre-commit error (1 line change) Mar 12, 2026
@vllm-bot vllm-bot merged commit 85199f9 into vllm-project:main Mar 12, 2026
14 checks passed
athrael-soju pushed a commit to athrael-soju/vllm that referenced this pull request Mar 16, 2026
…ct#36897)

Signed-off-by: SoluMilken <ypiheyn.imm02g@g2.nctu.edu.tw>
Signed-off-by: Athrael Soju <athrael.soju@gmail.com>
Lucaskabela pushed a commit to Lucaskabela/vllm that referenced this pull request Mar 17, 2026
…ct#36897)

Signed-off-by: SoluMilken <ypiheyn.imm02g@g2.nctu.edu.tw>
wendyliu235 pushed a commit to wendyliu235/vllm-public that referenced this pull request Mar 18, 2026
…ct#36897)

Signed-off-by: SoluMilken <ypiheyn.imm02g@g2.nctu.edu.tw>
fxdawnn pushed a commit to fxdawnn/vllm that referenced this pull request Mar 19, 2026
…ct#36897)

Signed-off-by: SoluMilken <ypiheyn.imm02g@g2.nctu.edu.tw>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants