[Bugfix] fix main branch pre-commit error (1 line change)#36897
Merged
vllm-bot merged 1 commit intovllm-project:mainfrom Mar 12, 2026
Merged
[Bugfix] fix main branch pre-commit error (1 line change)#36897vllm-bot merged 1 commit intovllm-project:mainfrom
vllm-bot merged 1 commit intovllm-project:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request aims to fix a pre-commit error by changing the skip condition in a test. However, the proposed change from a CUDA-specific check to a generic accelerator check introduces a potential issue. The test itself remains CUDA-specific, which will cause it to fail on systems with non-CUDA accelerators. My review provides a correction to use the idiomatic torch.cuda.is_available() for the skip condition, aligning it with the test's implementation.
02c8782 to
bb4fbba
Compare
Signed-off-by: SoluMilken <ypiheyn.imm02g@g2.nctu.edu.tw>
bb4fbba to
38c447d
Compare
mgoin
approved these changes
Mar 12, 2026
athrael-soju
pushed a commit
to athrael-soju/vllm
that referenced
this pull request
Mar 16, 2026
…ct#36897) Signed-off-by: SoluMilken <ypiheyn.imm02g@g2.nctu.edu.tw> Signed-off-by: Athrael Soju <athrael.soju@gmail.com>
Lucaskabela
pushed a commit
to Lucaskabela/vllm
that referenced
this pull request
Mar 17, 2026
…ct#36897) Signed-off-by: SoluMilken <ypiheyn.imm02g@g2.nctu.edu.tw>
wendyliu235
pushed a commit
to wendyliu235/vllm-public
that referenced
this pull request
Mar 18, 2026
…ct#36897) Signed-off-by: SoluMilken <ypiheyn.imm02g@g2.nctu.edu.tw>
fxdawnn
pushed a commit
to fxdawnn/vllm
that referenced
this pull request
Mar 19, 2026
…ct#36897) Signed-off-by: SoluMilken <ypiheyn.imm02g@g2.nctu.edu.tw>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
https://github.com/vllm-project/vllm/actions/runs/23009533389/job/66815794167
Test Plan
pre-commit run --show-diff-on-failure --color=always --all-files --hook-stage manualTest Result
https://github.com/vllm-project/vllm/actions/runs/23010892261/job/66820778095?pr=36897

Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.