[bnb] Skip moe + bnb test#36896
Conversation
There was a problem hiding this comment.
Code Review
This pull request skips a failing test related to MoE models with bitsandbytes quantization, which is a reasonable temporary measure. My review includes one suggestion to add a tracking issue to the skip reason. This is an important practice to ensure the test is re-enabled once the underlying issue is resolved, thereby maintaining long-term test coverage and code health.
| @@ -138,6 +138,7 @@ def test_load_pp_4bit_bnb_model(model_name, description) -> None: | |||
| compare_two_settings(model_name, common_args, pp_args) | |||
|
|
|||
|
|
|||
| @pytest.mark.skip(reason="Need to add support for quantizing MoE experts with bnb in transformers") | |||
There was a problem hiding this comment.
To ensure this skipped test is eventually re-enabled, it's crucial to track the underlying issue. Please create a GitHub issue for the lack of support for quantizing MoE experts with bnb and reference it in the skip reason. This prevents the test skip from becoming permanent and forgotten, which would create a lasting gap in test coverage.
| @pytest.mark.skip(reason="Need to add support for quantizing MoE experts with bnb in transformers") | |
| @pytest.mark.skip(reason="BNB integration does not support quantizing MoE with 3D params yet. See issue #XYZ.") |
|
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run You ask your reviewers to trigger select CI tests on top of Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add If you have any questions, please reach out to us on Slack at https://slack.vllm.ai. 🚀 |
Signed-off-by: Marc Sun <marc@huggingface.co>
Signed-off-by: Marc Sun <marc@huggingface.co>
|
Hi @SunMarc, the pre-commit checks have failed. Please run: uv pip install pre-commit
pre-commit install
pre-commit run --all-filesThen, commit the changes and push to your branch. For future commits, Tip Is
|
Signed-off-by: Marc Sun <marc@huggingface.co>
Head branch was pushed to by a user without write access
1f58c45 to
03ca08e
Compare
Signed-off-by: Marc Sun <marc@huggingface.co>
Signed-off-by: Marc Sun <marc@huggingface.co>
Signed-off-by: Marc Sun <marc@huggingface.co>
Signed-off-by: Marc Sun <marc@huggingface.co>
What does this PR do ?
This PR skips the
test_4bit_bnb_moe_modeltest because in v5, the MoE implementation changed to 3D params and our bnb integration don't support quantizing 3D params yet. So, this is might be why it is failing since the two models are not the same. Note that on H100, the test actually pass but on the CI, it's always failing.cc @hmellor