Skip to content

[ROCm] Validate block_size for explicitly selected attention backends #36846

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gshtras merged 4 commits into from
Mar 17, 2026
Merged

[ROCm] Validate block_size for explicitly selected attention backends #36846

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a32370a
[ROCm] Validate block_size for explicitly selected attention backends
AndreasKaratzas Mar 12, 2026
5624efe
Merge remote-tracking branch 'origin/main' into akaratza_fix_atten_di…
AndreasKaratzas Mar 14, 2026
27ac353
Merge remote-tracking branch 'origin/main' into akaratza_fix_atten_di…
AndreasKaratzas Mar 16, 2026
e72a473
[ROCm] Remove block_size strip; validate via supports_block_size
AndreasKaratzas Mar 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions vllm/platforms/rocm.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -438,8 +438,6 @@ def get_attn_backend_cls(
device_capability = cls.get_device_capability()
assert device_capability is not None

attn_selector_config = attn_selector_config._replace(block_size=None)

# First try checking just the selected backend, if there is one.
if selected_backend is not None:
try:
Expand Down
Loading