Skip to content

[Misc] Add online audio_in_video test#36775

Merged
vllm-bot merged 9 commits intovllm-project:mainfrom
Isotr0py:test-audio-in-video
Mar 15, 2026
Merged

[Misc] Add online audio_in_video test#36775
vllm-bot merged 9 commits intovllm-project:mainfrom
Isotr0py:test-audio-in-video

Conversation

@Isotr0py
Copy link
Member

@Isotr0py Isotr0py commented Mar 11, 2026

Purpose

Test Plan

pytest -s -v tests/multimodal/media/test_audio.py -k test_audio_media_io_from_video
pytest -s -v tests/models/multimodal/generation/test_qwen2_5_omni.py

Test Result

Tests should pass.


Essential Elements of an Effective PR Description Checklist
  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.
  • (Optional) Release notes update. If your change is user facing, please update the release notes draft in the Google Doc.

@mergify mergify bot added multi-modality Related to multi-modality (#4194) qwen Related to Qwen models labels Mar 11, 2026
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds tests for the audio_in_video feature. A new end-to-end test is added for the Qwen2.5-Omni model to verify online serving with audio extracted from video. Additionally, a unit test is added to test_audio.py to verify the AudioMediaIO.load_bytes method's capability to extract audio from video bytes. The changes are a good addition, but there is a critical issue in the new end-to-end test where a local, hardcoded model path is used. This will prevent the test from running in other environments and needs to be addressed.

@Isotr0py Isotr0py marked this pull request as ready for review March 11, 2026 13:30
@DarkLight1337 DarkLight1337 added the ready ONLY add when PR is ready to merge/full CI is needed label Mar 11, 2026
@DarkLight1337 DarkLight1337 enabled auto-merge (squash) March 11, 2026 14:43
Signed-off-by: Isotr0py <mozf@mail2.sysu.edu.cn>
Signed-off-by: Isotr0py <mozf@mail2.sysu.edu.cn>
Signed-off-by: Isotr0py <mozf@mail2.sysu.edu.cn>
Signed-off-by: Isotr0py <mozf@mail2.sysu.edu.cn>
@Isotr0py Isotr0py force-pushed the test-audio-in-video branch from 3bbb1d1 to 7a45b27 Compare March 12, 2026 04:40
Signed-off-by: Isotr0py <mozf@mail2.sysu.edu.cn>
@mergify mergify bot added the ci/build label Mar 12, 2026
Signed-off-by: Isotr0py <mozf@mail2.sysu.edu.cn>
@mergify
Copy link

mergify bot commented Mar 12, 2026

Hi @Isotr0py, the pre-commit checks have failed. Please run:

uv pip install pre-commit
pre-commit install
pre-commit run --all-files

Then, commit the changes and push to your branch.

For future commits, pre-commit will run automatically on changed files before each commit.

Tip

Is mypy failing?
mypy is run differently in CI. If the failure is related to this check, please use the following command to run it locally:
# For mypy (substitute "3.10" with the failing version if needed)
pre-commit run --hook-stage manual mypy-3.10

@mergify
Copy link

mergify bot commented Mar 12, 2026

Hi @Isotr0py, the pre-commit checks have failed. Please run:

uv pip install pre-commit
pre-commit install
pre-commit run --all-files

Then, commit the changes and push to your branch.

For future commits, pre-commit will run automatically on changed files before each commit.

Tip

Is mypy failing?
mypy is run differently in CI. If the failure is related to this check, please use the following command to run it locally:
# For mypy (substitute "3.10" with the failing version if needed)
pre-commit run --hook-stage manual mypy-3.10

@Isotr0py Isotr0py requested a review from njhill as a code owner March 14, 2026 13:58
@mergify mergify bot added the frontend label Mar 14, 2026
@vllm-bot vllm-bot merged commit 143e4dc into vllm-project:main Mar 15, 2026
113 of 115 checks passed
@Isotr0py Isotr0py deleted the test-audio-in-video branch March 15, 2026 08:00
athrael-soju pushed a commit to athrael-soju/vllm that referenced this pull request Mar 16, 2026
Signed-off-by: Isotr0py <mozf@mail2.sysu.edu.cn>
Signed-off-by: Athrael Soju <athrael.soju@gmail.com>
Lucaskabela pushed a commit to Lucaskabela/vllm that referenced this pull request Mar 17, 2026
Signed-off-by: Isotr0py <mozf@mail2.sysu.edu.cn>
wendyliu235 pushed a commit to wendyliu235/vllm-public that referenced this pull request Mar 18, 2026
Signed-off-by: Isotr0py <mozf@mail2.sysu.edu.cn>
fxdawnn pushed a commit to fxdawnn/vllm that referenced this pull request Mar 19, 2026
Signed-off-by: Isotr0py <mozf@mail2.sysu.edu.cn>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci/build frontend multi-modality Related to multi-modality (#4194) qwen Related to Qwen models ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants