[Bugfix] Fix FP8 online quantization premature trigger with TP sharded weights#36621
Open
AjAnubolu wants to merge 1 commit intovllm-project:mainfrom
Open
[Bugfix] Fix FP8 online quantization premature trigger with TP sharded weights#36621AjAnubolu wants to merge 1 commit intovllm-project:mainfrom
AjAnubolu wants to merge 1 commit intovllm-project:mainfrom
Conversation
AjAnubolu
requested review from
mgoin,
pavanimajety,
robertgshaw2-redhat,
tlrmchlsmth and
yewentao256
as code owners
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request addresses a bug in FP8 online quantization for models with tensor parallelism. The change modifies the condition for triggering the weight processing from an equality check to a greater-than-or-equal-to check. This is intended to make the logic more robust against edge cases with sharded weights. New regression tests have been added to cover this scenario and verify the behavior of the CopyNumelCounter.
Contributor
|
@AjAnubolu could you share which models hit this edge case so we are aware? note that #33814 should also take care of this |
…d weights Signed-off-by: AjAnubolu <anuboluajay@gmail.com>
AjAnubolu
force-pushed
the
fix/fp8-tp-empty-output-36583
branch
from
4635dc9 to
f3d6e91
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use >= instead of == for loaded numel check to guard against edge cases in copy_ tracking with TP > 1.
Closes #36583