Skip to content

[Bugfix] Fix DP wave race condition re-arming engine while paused #36608

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AjAnubolu wants to merge 1 commit into
base: main
Choose a base branch
from
+1 −1
Open

[Bugfix] Fix DP wave race condition re-arming engine while paused #36608

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion vllm/v1/engine/core.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1578,7 +1578,7 @@ def _handle_client_request(
new_wave >= self.current_wave
):
self.current_wave = new_wave
if not self.engines_running:
if not self.engines_running and not self.is_scheduler_paused():
logger.debug("EngineCore starting idle loop for wave %d.", new_wave)
self.engines_running = True
else:
Expand Down
Loading