-
-
Notifications
You must be signed in to change notification settings - Fork 15.7k
[Bugfix] Warm up Triton autotuner for GDN layers during V1 profiling #36599
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+98
−1
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
70f7d7c
[Bugfix] Warm up Triton autotuner for GDN layers during V1 profiling
AuYang261 60a8085
Move warmup success log inside try block
AuYang261 16cf800
Address review: rename method, remove @no_grad, clarify decode path
AuYang261 907ae15
Warmup all BT values for chunk_fwd_kernel_o
AuYang261 0220d64
Use get_state_dtype() for warmup state tensor
AuYang261 53f61de
Merge branch 'main' into fix/gdn-triton-warmup
AuYang261 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Upstream removed the different
BTvalues inchunk_fwd_kernel_oin fla-org/flash-linear-attention#619 which now always setsBT = chunk_size.Should we do the same in our kernels which would simplify this, or was this change deliberately not pulled in? This would be equivalent to the current behaviour with
FLA_GDN_FIX_BT=1. @AuYang261 @ywang96 @ZJY0516 What do you think?vllm/vllm/model_executor/layers/fla/ops/chunk_o.py
Line 153 in d860601
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I based the
_warmup_prefill_kernelson the existingchunk_fwd_kernel_ologic where BT varies with chunk_size, and wasn't aware of the upstream simplification. Happy to defer to maintainers on whether to pull that in.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If it improves performance, user experience, or stability, we should keep it in sync with upstream.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Refer to #38343 @lgeiger @ZJY0516