Skip to content

[ROCm][CI] Retrying in case of batch variance effects and reducing flakiness #36442

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tjtanaa merged 4 commits into from
Mar 16, 2026
Merged

[ROCm][CI] Retrying in case of batch variance effects and reducing flakiness #36442

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
64c9111
[ROCm][CI] Retrying in case of batch variance effects and reducing fl…
AndreasKaratzas Mar 9, 2026
927f522
Merge remote-tracking branch 'origin/main' into akaratza_stabilize_v1…
AndreasKaratzas Mar 14, 2026
008e9a0
Merge remote-tracking branch 'origin/main' into akaratza_stabilize_v1…
AndreasKaratzas Mar 15, 2026
cd8f729
Removed env override for ROCm
AndreasKaratzas Mar 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions tests/v1/e2e/general/test_async_scheduling.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,10 @@
import pytest
import torch._dynamo.config as dynamo_config

from tests.utils import large_gpu_mark, single_gpu_only
from tests.utils import (
large_gpu_mark,
single_gpu_only,
)
from vllm import SamplingParams
from vllm.logprobs import Logprob
from vllm.platforms import current_platform
Expand Down Expand Up @@ -150,6 +153,7 @@ def test_with_eagle3_spec_decoding(sample_json_schema, monkeypatch: pytest.Monke
run_tests(monkeypatch, MTP_MODEL, test_configs, test_sampling_params)


@pytest.mark.flaky(reruns=2, only_on=current_platform.is_rocm())
def test_with_ngram_gpu_spec_decoding(monkeypatch: pytest.MonkeyPatch):
"""Test ngram_gpu speculative decoding with different configurations.

Expand Down Expand Up @@ -202,7 +206,6 @@ def run_tests(
with monkeypatch.context() as m:
# lock matmul precision to full FP32 (IEEE)
m.setenv("VLLM_FLOAT32_MATMUL_PRECISION", "highest")
# m.setenv("VLLM_BATCH_INVARIANT", "1")
outputs: list[tuple[str, list, list]] = []
for n, (
test_preemption,
Expand Down Expand Up @@ -351,6 +354,7 @@ def run_test(
speculative_config=spec_config,
disable_log_stats=False,
attention_config=attention_config,
enable_prefix_caching=False if current_platform.is_rocm() else None,
**cache_arg,
) as vllm_model:
results = []
Expand Down
Loading