Skip to content

[Bugfix] Remove incorrect assertion in causal_conv1d_update for Qwen3.5 GDN layersfix: remove incorrect assertion in causal_conv1d_update for GDN index… #36324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Rks2302 wants to merge 4 commits into
base: main
Choose a base branch
from
Open

[Bugfix] Remove incorrect assertion in causal_conv1d_update for Qwen3.5 GDN layersfix: remove incorrect assertion in causal_conv1d_update for GDN index… #36324

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f091b96
[Bugfix] Fix compressed-tensors quantization failure for DeepSeek-R1 …
vllmellm Mar 7, 2026
444783f
fix: remove incorrect assertion in causal_conv1d_update for GDN index…
Rks2302 Mar 7, 2026
69929f5
Merge branch 'main' into fix/gdn-causal-conv1d-assertion
Rks2302 Mar 7, 2026
275bc8a
Merge branch 'main' into fix/gdn-causal-conv1d-assertion
Rks2302 Mar 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions vllm/model_executor/layers/mamba/ops/causal_conv1d.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1158,8 +1158,6 @@ def causal_conv1d_update(
assert batch == conv_state_indices.shape[0], (
f"ERROR: conv_state_indices should have shape ({batch},*) but got {conv_state_indices.shape}"
)

assert num_cache_lines >= batch
assert weight.stride(1) == 1 # Need this

# adopt the strategy in vLLM that overwrite on 'x' directly, rather than creating a new tensor 'o'
Expand Down