[BugFix]: add bagel to MM_PREFIX_LM_MODELS#36316
Conversation
Signed-off-by: princepride <wangzhipeng628@gmail.com>
princepride
requested review from
ProExpertProg,
WoosukKwon,
hmellor,
houseroad,
mgoin,
robertgshaw2-redhat,
tlrmchlsmth,
yewentao256 and
youkaichao
as code owners
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds 'bagel' to the MM_PREFIX_LM_MODELS list in vllm/config/model.py. This change is intended to enable support for the 'bagel' model as a prefix-capable multimodal language model. The modification is a single-line addition. I have reviewed the code change and have no feedback at the requested severity levels (high, critical).
|
@Isotr0py PTAL, in this pr: vllm-project/vllm-omni#1669, I found that the multi-stage img2img task can't get the same result as the single stage img2img task result. After I check the code, I found bagel use bidirectional attention in vision latent. |
github-actions
Bot
added
the
ready
|
@tjtanaa CI failed |
|
@Isotr0py I don't know why CI failed ...😯 |
|
The CI is pretty red recently. 😢 Will request force merge if this time it's still red. |
|
😅 |
Signed-off-by: princepride <wangzhipeng628@gmail.com>
Signed-off-by: princepride <wangzhipeng628@gmail.com>
Signed-off-by: princepride <wangzhipeng628@gmail.com>
Signed-off-by: princepride <wangzhipeng628@gmail.com>
Signed-off-by: princepride <wangzhipeng628@gmail.com>
Signed-off-by: princepride <wangzhipeng628@gmail.com>
2 participants
Purpose
Add
bagelto theMM_PREFIX_LM_MODELSlist to support it as a prefix-capable multimodal language model.