[Bugfix][ROCm] Strip block_size before attention backend validation#36274
Merged
houseroad merged 3 commits intovllm-project:mainfrom Mar 11, 2026
Merged
[Bugfix][ROCm] Strip block_size before attention backend validation#36274houseroad merged 3 commits intovllm-project:mainfrom
houseroad merged 3 commits intovllm-project:mainfrom
Conversation
The ROCm attention backend refactor (vllm-project#35246) introduced validate_configuration calls that reject block_size=544 because it is not in the BlockSize type (1, 8, 16, 32, 64, 128, 256). The CUDA platform avoids this by stripping block_size before validation. Apply the same fix to the ROCm platform. Signed-off-by: jennyyyyzhen <yzhen@hmc.edu>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request addresses a bug on the ROCm platform where attention backend validation was failing for irregular block_size values. The fix, which mirrors the existing logic for the CUDA platform, involves stripping the block_size from the attention selector configuration before the validation step. This is a clean and targeted solution that resolves the issue, allowing models with non-standard block sizes to run correctly on ROCm. The change is well-contained and appears correct.
Contributor
Author
|
@houseroad can you help review? |
1 task
wendyliu235
pushed a commit
to wendyliu235/vllm-public
that referenced
this pull request
Mar 18, 2026
…llm-project#36274) Signed-off-by: jennyyyyzhen <yzhen@hmc.edu> Co-authored-by: Lu Fang <30275821+houseroad@users.noreply.github.com>
fxdawnn
pushed a commit
to fxdawnn/vllm
that referenced
this pull request
Mar 19, 2026
…llm-project#36274) Signed-off-by: jennyyyyzhen <yzhen@hmc.edu> Co-authored-by: Lu Fang <30275821+houseroad@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
The ROCm attention backend refactor (#35246) introduced validate_configuration calls that reject irregular block_size because it is not in the BlockSize type (1, 8, 16, 32, 64, 128, 256). The CUDA platform avoids this by stripping block_size before validation. Apply the same fix to the ROCm platform.
Test Plan
Can start Qwen3 Next correctly
Test Result
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.