Skip to content

pick up tuned prefill configs for FP8 FA3#36265

Merged
vllm-bot merged 9 commits intovllm-project:mainfrom
jmkuebler:patch-2
Mar 17, 2026
Merged

pick up tuned prefill configs for FP8 FA3#36265
vllm-bot merged 9 commits intovllm-project:mainfrom
jmkuebler:patch-2

Conversation

@jmkuebler
Copy link
Copy Markdown
Contributor

@jmkuebler jmkuebler commented Mar 6, 2026

Purpose

Run CI for vllm-project/flash-attention#125
Benchmarking results are in FA PR

Signed-off-by: Jonas M. Kübler <44084297+jmkuebler@users.noreply.github.com>
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the pinned commit for the flash-attention dependency to 192c71ae3fb2b474e06f5473bb1a7d41baefbd3f. According to the title, this is to incorporate tuned prefill configurations for FP8 FlashAttention 3. While pinning dependencies to a specific commit is a good practice for reproducibility, using a raw commit hash without any context makes the code harder to maintain. I've suggested adding a comment to clarify the purpose of this specific commit hash.

Signed-off-by: Jonas Kuebler <kuebj@amazon.com>
@MatthewBonanni MatthewBonanni added the ready ONLY add when PR is ready to merge/full CI is needed label Mar 10, 2026
@mergify
Copy link
Copy Markdown

mergify bot commented Mar 12, 2026

Hi @jmkuebler, the pre-commit checks have failed. Please run:

uv pip install pre-commit
pre-commit install
pre-commit run --all-files

Then, commit the changes and push to your branch.

For future commits, pre-commit will run automatically on changed files before each commit.

Tip

Is mypy failing?
mypy is run differently in CI. If the failure is related to this check, please use the following command to run it locally:
# For mypy (substitute "3.10" with the failing version if needed)
pre-commit run --hook-stage manual mypy-3.10

@mergify
Copy link
Copy Markdown

mergify bot commented Mar 12, 2026

This pull request has merge conflicts that must be resolved before it can be
merged. Please rebase the PR, @jmkuebler.

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

@mergify mergify bot added the needs-rebase label Mar 12, 2026
Signed-off-by: Jonas M. Kübler <44084297+jmkuebler@users.noreply.github.com>
@mergify mergify bot removed the needs-rebase label Mar 12, 2026
@LucasWilkinson LucasWilkinson added the ready-run-all-tests Trigger CI with all tests for wide-ranging PRs label Mar 15, 2026
Signed-off-by: Jonas Kuebler <kuebj@amazon.com>
@MatthewBonanni MatthewBonanni enabled auto-merge (squash) March 16, 2026 18:17
@vllm-bot vllm-bot merged commit 77d2a5f into vllm-project:main Mar 17, 2026
165 of 168 checks passed
@jmkuebler jmkuebler deleted the patch-2 branch March 17, 2026 14:06
Lucaskabela pushed a commit to Lucaskabela/vllm that referenced this pull request Mar 17, 2026
Signed-off-by: Jonas M. Kübler <44084297+jmkuebler@users.noreply.github.com>
Signed-off-by: Jonas Kuebler <kuebj@amazon.com>
andylolu2 pushed a commit to andylolu2/vllm that referenced this pull request Mar 18, 2026
Signed-off-by: Jonas M. Kübler <44084297+jmkuebler@users.noreply.github.com>
Signed-off-by: Jonas Kuebler <kuebj@amazon.com>
wendyliu235 pushed a commit to wendyliu235/vllm-public that referenced this pull request Mar 18, 2026
Signed-off-by: Jonas M. Kübler <44084297+jmkuebler@users.noreply.github.com>
Signed-off-by: Jonas Kuebler <kuebj@amazon.com>
fxdawnn pushed a commit to fxdawnn/vllm that referenced this pull request Mar 19, 2026
Signed-off-by: Jonas M. Kübler <44084297+jmkuebler@users.noreply.github.com>
Signed-off-by: Jonas Kuebler <kuebj@amazon.com>
khairulkabir1661 pushed a commit to khairulkabir1661/vllm that referenced this pull request Mar 27, 2026
Signed-off-by: Jonas M. Kübler <44084297+jmkuebler@users.noreply.github.com>
Signed-off-by: Jonas Kuebler <kuebj@amazon.com>
Monishver11 pushed a commit to Monishver11/vllm that referenced this pull request Mar 27, 2026
Signed-off-by: Jonas M. Kübler <44084297+jmkuebler@users.noreply.github.com>
Signed-off-by: Jonas Kuebler <kuebj@amazon.com>
Signed-off-by: Monishver Chandrasekaran <monishverchandrasekaran@gmail.com>
JiantaoXu pushed a commit to JiantaoXu/vllm that referenced this pull request Mar 28, 2026
Signed-off-by: Jonas M. Kübler <44084297+jmkuebler@users.noreply.github.com>
Signed-off-by: Jonas Kuebler <kuebj@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci/build ready ONLY add when PR is ready to merge/full CI is needed ready-run-all-tests Trigger CI with all tests for wide-ranging PRs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants