-
-
Notifications
You must be signed in to change notification settings - Fork 16.2k
[main][feature] Support quarot for eagle3 #36225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
drslark
wants to merge
1
commit into
vllm-project:main
Choose a base branch
from
drslark:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+70
−0
Draft
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -875,3 +875,40 @@ | |||||||||||||||||
| if feature_layer_index < 0: | ||||||||||||||||||
| return num_hidden_layers + feature_layer_index + 1 | ||||||||||||||||||
| return feature_layer_index | ||||||||||||||||||
|
|
||||||||||||||||||
|
|
||||||||||||||||||
| def get_rotation_path(target_model_path, quant_config): | ||||||||||||||||||
| """ | ||||||||||||||||||
| Gets the path of the rotation matrix, returns None if the target model is not a quarot model. | ||||||||||||||||||
| """ | ||||||||||||||||||
| try: | ||||||||||||||||||
| rotation_relative_path = quant_config.quant_description["optional"]["quarot"]["rotation_map"][ | ||||||||||||||||||
| "global_rotation" | ||||||||||||||||||
| ] | ||||||||||||||||||
| except KeyError: | ||||||||||||||||||
| return None | ||||||||||||||||||
|
|
||||||||||||||||||
| return Path(target_model_path) / rotation_relative_path | ||||||||||||||||||
|
|
||||||||||||||||||
|
|
||||||||||||||||||
| def get_rotataion_matrix(rotation_path): | ||||||||||||||||||
| """ | ||||||||||||||||||
| Anti-rotate maxtrix. | ||||||||||||||||||
| """ | ||||||||||||||||||
|
Comment on lines
+894
to
+897
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. There's a typo in the function name (
Suggested change
|
||||||||||||||||||
| try: | ||||||||||||||||||
| safetensor_data = load_file(rotation_path) | ||||||||||||||||||
| Q = safetensor_data["global_rotation"] | ||||||||||||||||||
|
|
||||||||||||||||||
| return Q | ||||||||||||||||||
| except Exception as e: | ||||||||||||||||||
| logger.error( | ||||||||||||||||||
| f"Failed to load rotation weight from '{rotation_path}'. " | ||||||||||||||||||
| "If you want to use quarot model with eagle3, take a check." | ||||||||||||||||||
| ) | ||||||||||||||||||
| raise e | ||||||||||||||||||
|
|
||||||||||||||||||
| def compute_rotataion_matrix3(Q): | ||||||||||||||||||
| """ | ||||||||||||||||||
| Anti-rotate matrix for 3 layers of hidden_states. | ||||||||||||||||||
| """ | ||||||||||||||||||
| return torch.block_diag(Q, Q, Q) | ||||||||||||||||||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The function
get_embedding_tensoris called here but it is not defined or imported in this file, nor is it defined in this pull request. This will cause aNameErrorat runtime.