[Bugfix] Filter None compilation times in Executor#36186
Open
842974287 wants to merge 1 commit intovllm-project:mainfrom
Open
[Bugfix] Filter None compilation times in Executor#36186842974287 wants to merge 1 commit intovllm-project:mainfrom
842974287 wants to merge 1 commit intovllm-project:mainfrom
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request addresses two key issues: it fixes a critical initialization order bug in WorkerProc for multi-node setups by moving _init_message_queues to after init_device, and it adds a filter to remove None values from compilation_times to prevent potential TypeError exceptions. No security vulnerabilities were found in these changes.
842974287
changed the title
Member
|
Thanks @842974287! There is already a PR for this that should hopefully be merged very soon #35892. Perhaps you can update this one to just cover the secondary fix, or open another PR for that. |
842974287
changed the title
842974287
force-pushed
the
fix-multinode-workerproc-init-ordering
branch
from
9b0b262 to
3bc708f
Compare
Contributor
Author
|
@njhill Thanks, updated PR. |
When workers return None for compilation_time (e.g. when compilation is skipped), max() raises a TypeError. Filter out None values before computing the maximum. Signed-off-by: Daosheng Yang <dsy842974287@users.noreply.github.com> Signed-off-by: Shiyan Deng <dsy842974287@meta.com>
842974287
force-pushed
the
fix-multinode-workerproc-init-ordering
branch
from
3bc708f to
1318d0a
Compare
|
Could we land this? it's breaking some critical CIs on the mtia side |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
When workers return
Noneforcompilation_time(e.g. when compilation is skipped),max()on the collected results raises aTypeError. This filters outNonevalues before computing the maximum.Test Plan
max()no longer raises whencompilation_timescontainsNonevalues.Test Result
No regression — the fix is a single-line defensive filter.
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.