Conversation
|
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run You ask your reviewers to trigger select CI tests on top of Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add If you have any questions, please reach out to us on Slack at https://slack.vllm.ai. 🚀 |
There was a problem hiding this comment.
Code Review
This pull request correctly addresses a build failure on CUDA versions older than 12.4 by adding a preprocessor guard (#if CUDA_VERSION >= 12040) around code that uses APIs specific to CUDA 12.4 and later. The change is well-contained, uses the standard version macro, and correctly maintains the existing logic for older toolchains. The fix is appropriate and I see no issues with the implementation.
CU_DEVICE_ATTRIBUTE_HANDLE_TYPE_FABRIC_SUPPORTED and CU_MEM_HANDLE_TYPE_FABRIC were introduced in CUDA 12.4. Without a version guard, cumem_allocator.cpp fails to compile on CUDA 12.0–12.3. Wrap the fabric detection block in #if CUDA_VERSION >= 12040 so that older toolchains skip fabric support gracefully. fab_flag remains initialized to 0, so the existing fallback logic is unaffected. Tested: compiles cleanly on CUDA 12.0 (V12.0.140) and CUDA 12.8 (V12.8.61). Introduced in #33540. Signed-off-by: Nikolaos Ioannidis <ni@aimbit.de>
5bdcebf to
ea772e5
Compare
|
This pull request has merge conflicts that must be resolved before it can be |
|
This pull request has been automatically marked as stale because it has not had any activity within 90 days. It will be automatically closed if no further activity occurs within 30 days. Leave a comment if you feel this pull request should remain open. Thank you! |
Summary
CU_DEVICE_ATTRIBUTE_HANDLE_TYPE_FABRIC_SUPPORTEDandCU_MEM_HANDLE_TYPE_FABRICwere introduced in CUDA 12.4cumem_allocator.cppfails to compile on CUDA 12.0–12.3#if CUDA_VERSION >= 12040so older toolchains skip fabric support gracefullyfab_flagremains initialized to 0, so the existing fallback logic at line 130 is unaffectedIntroduced in #33540.
Test plan
pre-commit run --files csrc/cumem_allocator.cpppasses (clang-format, typos)Signed-off-by: Nikolaos Ioannidis ni@aimbit.de