[NIXL][Bugfix] metrics & testing minor bug

[andylolu2]

Purpose

Minor bug fixes:

• NIXL handshake: add agent took log was not counting the time spent on add_remote_agent, which is what it's supposed to log.
• The test_prefill_tp_size_greater_than_decode_tp_size was not testing the local_tp_size case because of an override.

[gemini-code-assist]

Code Review

This pull request addresses two minor bugs. The first is a test fix in test_prefill_tp_size_greater_than_decode_tp_size which removes a hardcoded variable, allowing the test to correctly use its parameterization. The second is a metrics fix in _nixl_handshake that adjusts the timing logic to correctly include the duration of the add_remote_agent call in the log. Both changes are correct and effectively resolve the described issues.

[mergify]

Hi @andylolu2, the pre-commit checks have failed. Please run:

uv pip install pre-commit
pre-commit install
pre-commit run --all-files

Then, commit the changes and push to your branch.

For future commits, pre-commit will run automatically on changed files before each commit.

Tip

Is mypy or markdownlint failing?

mypy and markdownlint are run differently in CI. If the failure is related to either of these checks, please use the following commands to run them locally:

# For mypy (substitute "3.10" with the failing version if needed)
pre-commit run --hook-stage manual mypy-3.10
# For markdownlint
pre-commit run --hook-stage manual markdownlint

[NickLucche]

Thanks @andylolu2 , can you quickly check pre-commit here?

[andylolu2]

Thanks @andylolu2 , can you quickly check pre-commit here?

I think main was broken for a bit, will rebase

[mergify]

This pull request has merge conflicts that must be resolved before it can be
merged. Please rebase the PR, @andylolu2.

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

[andylolu2]

The test actually doesn't work with local_tp_size == remote_tp_size