[Model Runner V2] Fix inputs_embeds=None bug for MM models#35917
Merged
WoosukKwon merged 1 commit intomainfrom Mar 3, 2026
Merged
[Model Runner V2] Fix inputs_embeds=None bug for MM models#35917WoosukKwon merged 1 commit intomainfrom
WoosukKwon merged 1 commit intomainfrom
Conversation
Signed-off-by: Woosuk Kwon <woosuk@inferact.ai>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request correctly fixes a bug for multi-modal (MM) models where inputs_embeds was None during dummy runs, such as for profiling or CUDA graph capture. The change ensures that get_mm_embeddings is always called for MM models, providing a consistent tensor input for inputs_embeds in both dummy and real runs. This prevents issues with CUDA graph compilation, which expects consistent input shapes and types. The change is sound and I have no further comments.
njhill
approved these changes
Mar 3, 2026
Copilot AI
pushed a commit
to machov/vllm
that referenced
this pull request
Mar 10, 2026
…ect#35917) Signed-off-by: Woosuk Kwon <woosuk@inferact.ai>
avinashsingh77
pushed a commit
to avinashsingh77/vllm
that referenced
this pull request
Mar 12, 2026
…ect#35917) Signed-off-by: Woosuk Kwon <woosuk@inferact.ai>
wendyliu235
pushed a commit
to wendyliu235/vllm-public
that referenced
this pull request
Mar 18, 2026
…ect#35917) Signed-off-by: Woosuk Kwon <woosuk@inferact.ai>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug that VLMs see blank images when CUDA graph is enabled (while the model works fine with eager mode). The bug is actually caused by incorrect compilation; We didn't provide
inputs_embedsfor the initial run.