Skip to content

[CI] And PPL test for Qwen3.5.#35853

Merged
noooop merged 6 commits intovllm-project:mainfrom
noooop:qwen3_5_ppl
Mar 3, 2026
Merged

[CI] And PPL test for Qwen3.5.#35853
noooop merged 6 commits intovllm-project:mainfrom
noooop:qwen3_5_ppl

Conversation

@noooop
Copy link
Copy Markdown
Collaborator

@noooop noooop commented Mar 3, 2026

Purpose

And PPL test for Qwen3.5.

Test Plan

tests/models/language/generation_ppl_test/test_qwen.py::test_ppl[model_info2]

Test Result

Model: Qwen/Qwen3.5-0.8B
VLLM: dtype:torch.bfloat16 head_dtype:torch.bfloat16 19.51075553894043
Transformers: Constant 19.38858413696289
Difference (%): 0.630120286837389


Essential Elements of an Effective PR Description Checklist
  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.
  • (Optional) Release notes update. If your change is user facing, please update the release notes draft in the Google Doc.

Signed-off-by: wang.yuqi <yuqi.wang@daocloud.io>
@mergify mergify Bot added the qwen Related to Qwen models label Mar 3, 2026
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds a PPL test for the Qwen3.5 model and optimizes existing PPL tests for Gemma, GPT, and other Qwen models by pre-calculating and hardcoding the Hugging Face perplexity scores. This is a good approach to speed up CI. The changes are mostly correct, but I've found a minor style inconsistency in one of the test files that should be addressed.

Comment thread tests/models/language/generation_ppl_test/test_qwen.py Outdated
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Signed-off-by: wang.yuqi <noooop@126.com>
@noooop noooop added the ready ONLY add when PR is ready to merge/full CI is needed label Mar 3, 2026
@mergify
Copy link
Copy Markdown
Contributor

mergify Bot commented Mar 3, 2026

Hi @noooop, the pre-commit checks have failed. Please run:

uv pip install pre-commit
pre-commit install
pre-commit run --all-files

Then, commit the changes and push to your branch.

For future commits, pre-commit will run automatically on changed files before each commit.

Tip

Is mypy or markdownlint failing?
mypy and markdownlint are run differently in CI. If the failure is related to either of these checks, please use the following commands to run them locally:
# For mypy (substitute "3.10" with the failing version if needed)
pre-commit run --hook-stage manual mypy-3.10
# For markdownlint
pre-commit run --hook-stage manual markdownlint

noooop added 2 commits March 3, 2026 17:33
Signed-off-by: wang.yuqi <yuqi.wang@daocloud.io>
Comment thread tests/models/language/generation_ppl_test/test_qwen.py
Copy link
Copy Markdown
Member

@Isotr0py Isotr0py left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise LGTM

Signed-off-by: wang.yuqi <yuqi.wang@daocloud.io>
@mergify
Copy link
Copy Markdown
Contributor

mergify Bot commented Mar 3, 2026

Hi @noooop, the pre-commit checks have failed. Please run:

uv pip install pre-commit
pre-commit install
pre-commit run --all-files

Then, commit the changes and push to your branch.

For future commits, pre-commit will run automatically on changed files before each commit.

Tip

Is mypy or markdownlint failing?
mypy and markdownlint are run differently in CI. If the failure is related to either of these checks, please use the following commands to run them locally:
# For mypy (substitute "3.10" with the failing version if needed)
pre-commit run --hook-stage manual mypy-3.10
# For markdownlint
pre-commit run --hook-stage manual markdownlint

Signed-off-by: wang.yuqi <noooop@126.com>
@noooop noooop enabled auto-merge (squash) March 3, 2026 12:31
@noooop noooop merged commit fd4a90f into vllm-project:main Mar 3, 2026
17 checks passed
@noooop noooop deleted the qwen3_5_ppl branch March 3, 2026 13:16
Copilot AI pushed a commit to machov/vllm that referenced this pull request Mar 10, 2026
Signed-off-by: wang.yuqi <yuqi.wang@daocloud.io>
Signed-off-by: wang.yuqi <noooop@126.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
avinashsingh77 pushed a commit to avinashsingh77/vllm that referenced this pull request Mar 12, 2026
Signed-off-by: wang.yuqi <yuqi.wang@daocloud.io>
Signed-off-by: wang.yuqi <noooop@126.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
wendyliu235 pushed a commit to wendyliu235/vllm-public that referenced this pull request Mar 18, 2026
Signed-off-by: wang.yuqi <yuqi.wang@daocloud.io>
Signed-off-by: wang.yuqi <noooop@126.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

qwen Related to Qwen models ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants