[Core] Move save_tensorized_model logic to Worker#35825
Merged
WoosukKwon merged 1 commit intovllm-project:mainfrom Mar 3, 2026
Merged
[Core] Move save_tensorized_model logic to Worker#35825WoosukKwon merged 1 commit intovllm-project:mainfrom
WoosukKwon merged 1 commit intovllm-project:mainfrom
Conversation
It's cleaner for this to live in the worker, it should then work for both V1 and V2 model runners. Signed-off-by: Nick Hill <nickhill123@gmail.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors the save_tensorized_model logic by moving it from GPUModelRunner to the Worker class. This change makes the logic more generic and available to both V1 and V2 model runners. The implementation has been moved, and imports have been updated accordingly. The new implementation in the Worker class correctly accesses the model and its configuration. The changes appear correct, and I have not identified any issues.
WoosukKwon
approved these changes
Mar 3, 2026
Copilot AI
pushed a commit
to machov/vllm
that referenced
this pull request
Mar 10, 2026
Signed-off-by: Nick Hill <nickhill123@gmail.com>
avinashsingh77
pushed a commit
to avinashsingh77/vllm
that referenced
this pull request
Mar 12, 2026
Signed-off-by: Nick Hill <nickhill123@gmail.com>
wendyliu235
pushed a commit
to wendyliu235/vllm-public
that referenced
this pull request
Mar 18, 2026
Signed-off-by: Nick Hill <nickhill123@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's cleaner for this to live in the worker, it should then work for both V1 and V2 model runners.