[CI] Fix AMD: V1 Others (mi325_1) Amd CI bug#35816
Conversation
Signed-off-by: yewentao256 <zhyanwentao@126.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request fixes a CI failure by extending the check for pre-quoted pytest marker expressions to include double-quoted strings. While this addresses the immediate issue, the underlying heuristic for detecting quoted strings is fragile. My review includes a suggestion to make this check more robust by verifying that the string starts and ends with quotes, which will prevent misinterpretation of unquoted strings containing quote characters (e.g., don't_run). This improvement will help prevent similar CI failures in the future.
|
I'm also facing following ci failed error. I think it is also related to this.
https://buildkite.com/vllm/ci/builds/54094/steps/canvas?jid=019cb172-06da-4804-a67d-801632ef5eff |
| commands: | ||
| # Only run tests that need exactly 2 GPUs | ||
| - pytest -v -s v1/e2e/test_spec_decode.py -k "tensor_parallelism" | ||
| - pytest -v -s v1/e2e/test_spec_decode.py -k 'tensor_parallelism' |
There was a problem hiding this comment.
This is another bug fix, so ' is needed
# ---- Command source selection ----
# Prefer VLLM_TEST_COMMANDS (preserves all inner quoting intact).
# Fall back to $* for backward compatibility, but warn that inner
# double-quotes will have been stripped by the calling shell.
if [[ -n "${VLLM_TEST_COMMANDS:-}" ]]; then
commands="${VLLM_TEST_COMMANDS}"
echo "Commands sourced from VLLM_TEST_COMMANDS (quoting preserved)"
|
FYTI we just reverted the changes to use |
Ohh, so you mean this PR is not needed any more? Feel free to close it if so |
4 participants
Purpose
Fixes https://buildkite.com/vllm/ci/builds/54064#019cb0df-37b0-4ad3-a37b-ad9446da1819
Test
Covered in CI