[Bugfix] Fix misnamed parameter in compressed_tensors_moe.py#35813
Merged
robertgshaw2-redhat merged 2 commits intovllm-project:mainfrom Mar 3, 2026
Merged
[Bugfix] Fix misnamed parameter in compressed_tensors_moe.py#35813robertgshaw2-redhat merged 2 commits intovllm-project:mainfrom
robertgshaw2-redhat merged 2 commits intovllm-project:mainfrom
Conversation
Signed-off-by: Bill Nell <bnell@redhat.com>
bnellnm
requested review from
mgoin,
pavanimajety,
robertgshaw2-redhat,
tlrmchlsmth and
yewentao256
as code owners
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request corrects a typo in vllm/model_executor/layers/quantization/compressed_tensors/compressed_tensors_moe.py. The parameter num_experts was being assigned from layer.num_local_experts, which is an incorrect attribute name. The change corrects this to layer.local_num_experts, which correctly references the number of local experts on the FusedMoE layer. This is a necessary bug fix and the implementation is correct.
robertgshaw2-redhat
approved these changes
Mar 2, 2026
github-actions
Bot
added
the
ready
yewentao256
approved these changes
Mar 3, 2026
Member
yewentao256
left a comment
yewentao256
left a comment
There was a problem hiding this comment.
LGTM, thanks for the work!
Copilot AI
pushed a commit
to machov/vllm
that referenced
this pull request
Mar 10, 2026
…oject#35813) Signed-off-by: Bill Nell <bnell@redhat.com> Co-authored-by: Robert Shaw <114415538+robertgshaw2-redhat@users.noreply.github.com>
avinashsingh77
pushed a commit
to avinashsingh77/vllm
that referenced
this pull request
Mar 12, 2026
…oject#35813) Signed-off-by: Bill Nell <bnell@redhat.com> Co-authored-by: Robert Shaw <114415538+robertgshaw2-redhat@users.noreply.github.com>
wendyliu235
pushed a commit
to wendyliu235/vllm-public
that referenced
this pull request
Mar 18, 2026
…oject#35813) Signed-off-by: Bill Nell <bnell@redhat.com> Co-authored-by: Robert Shaw <114415538+robertgshaw2-redhat@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Renamed
FusedMoElayer parameter fromnum_local_experts->local_num_experts.Test Plan
Ran RedHatAI/Mixtral-8x7B-Instruct-v0.1-FP8
Test Result
No error, correct results.
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.