[MoE Refactor] Remove SharedFusedMoE class#35782
Merged
robertgshaw2-redhat merged 5 commits intovllm-project:mainfrom Apr 21, 2026
Merged
[MoE Refactor] Remove SharedFusedMoE class#35782robertgshaw2-redhat merged 5 commits intovllm-project:mainfrom
robertgshaw2-redhat merged 5 commits intovllm-project:mainfrom
Conversation
bnellnm
requested review from
WoosukKwon,
hmellor,
jeejeelee,
luccafong,
mgoin,
njhill,
pavanimajety,
robertgshaw2-redhat,
sighingnow,
tjtanaa,
tlrmchlsmth and
yewentao256
as code owners
Contributor
|
This pull request has merge conflicts that must be resolved before it can be |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request is a significant and well-executed refactoring of the Mixture of Experts (MoE) implementation. By removing the SharedFusedMoE and ZeroExpertFusedMoE classes and introducing a more modular design with MoERunner and SharedExperts classes, the code becomes more maintainable and extensible. The new tests for the zero expert functionality are also a great addition. I've found one critical issue in the new chunking runner that could lead to a crash when processing zero tokens, which I've detailed in a specific comment.
bnellnm
removed request for
hmellor,
jeejeelee,
mgoin,
njhill,
pavanimajety,
sighingnow,
tjtanaa,
tlrmchlsmth and
yewentao256
bnellnm
requested review from
LucasWilkinson,
pavanimajety and
robertgshaw2-redhat
and removed request for
luccafong and
robertgshaw2-redhat
Signed-off-by: Bill Nell <bnell@redhat.com>
bnellnm
force-pushed
the
remove-shared-fused-moe
branch
from
10c87e0 to
f4b2e72
Compare
Contributor
|
This pull request has merge conflicts that must be resolved before it can be |
Signed-off-by: Bill Nell <bnell@redhat.com>
robertgshaw2-redhat
added
the
ready
Signed-off-by: Bill Nell <bnell@redhat.com>
Signed-off-by: Bill Nell <bnell@redhat.com>
robertgshaw2-redhat
approved these changes
Apr 21, 2026
Copilot AI
pushed a commit
to hongbolv/vllm
that referenced
this pull request
Apr 22, 2026
Signed-off-by: Bill Nell <bnell@redhat.com> Co-authored-by: hongbolv <33214277+hongbolv@users.noreply.github.com>
baonudesifeizhai
pushed a commit
to baonudesifeizhai/vllm
that referenced
this pull request
Apr 23, 2026
Signed-off-by: Bill Nell <bnell@redhat.com>
yzong-rh
pushed a commit
to yzong-rh/vllm
that referenced
this pull request
Apr 23, 2026
Signed-off-by: Bill Nell <bnell@redhat.com> Signed-off-by: Yifan <yzong@redhat.com>
avinashsingh77
pushed a commit
to avinashsingh77/vllm
that referenced
this pull request
Apr 27, 2026
Signed-off-by: Bill Nell <bnell@redhat.com> Signed-off-by: Avinash Singh <avinashsingh.rcoem@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
The
SharedFusedMoEclass is no longer needed. Its functionality has been moved intoFusedMoE,SharedExpertsandMoERunnerBase.Test Plan
CI tests + MoE refactoring tests
Test Result
cc @yzong-rh
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.