[Bugfix] Avoid src/dst as None in irecv/isend_tensor_dict#35754
Merged
vllm-bot merged 5 commits intovllm-project:mainfrom Mar 3, 2026
Merged
[Bugfix] Avoid src/dst as None in irecv/isend_tensor_dict#35754vllm-bot merged 5 commits intovllm-project:mainfrom
vllm-bot merged 5 commits intovllm-project:mainfrom
Conversation
mergify
Bot
added
ci/build
cpu
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request fixes a bug where src and dst could be None when using the custom CPU communication path by moving the default value assignment to an earlier point in the functions. It also improves the CPU smoke test script to check for failed requests, making the CI more robust. My review identifies a potential race condition in the test script that could lead to flaky tests. The core bug fix in the Python code appears correct and well-implemented.
Member
Author
|
Hi @yewentao256 Could you please help to check this PR? Thank you :) |
yewentao256
approved these changes
Mar 2, 2026
Member
yewentao256
left a comment
yewentao256
left a comment
There was a problem hiding this comment.
LGTM, thanks for the work!
| @@ -1,26 +1,43 @@ | |||
| #!/bin/bash | |||
| set -euox pipefail | |||
| export VLLM_CPU_CI_ENV=0 | |||
Member
Author
There was a problem hiding this comment.
It's to enable torch.compile for this test
Copilot AI
pushed a commit
to machov/vllm
that referenced
this pull request
Mar 10, 2026
…ct#35754) Signed-off-by: jiang1.li <jiang1.li@intel.com>
avinashsingh77
pushed a commit
to avinashsingh77/vllm
that referenced
this pull request
Mar 12, 2026
…ct#35754) Signed-off-by: jiang1.li <jiang1.li@intel.com>
wendyliu235
pushed a commit
to wendyliu235/vllm-public
that referenced
this pull request
Mar 18, 2026
…ct#35754) Signed-off-by: jiang1.li <jiang1.li@intel.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
src/dstshould be set before calling the CPU send/recvTest Plan
CI tests
Test Result
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.