Skip to content

[Bugfix] Guard mm_token_type_ids kwarg in get_mrope_input_positions #35711

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hmellor merged 4 commits into from
Mar 4, 2026
Merged

[Bugfix] Guard mm_token_type_ids kwarg in get_mrope_input_positions #35711

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f8d2d9d
[Bugfix] Guard mm_token_type_ids kwarg in get_mrope_input_positions
AndreasKaratzas Mar 2, 2026
564c680
[Bugfix] Guard mm_token_type_ids kwarg in get_mrope_input_positions
AndreasKaratzas Mar 2, 2026
8388c5a
Merge remote-tracking branch 'origin/main' into akaratza_fix_multi_mo…
AndreasKaratzas Mar 3, 2026
5b41c57
Merge remote-tracking branch 'origin/main' into akaratza_fix_multi_mo…
AndreasKaratzas Mar 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion vllm/model_executor/models/transformers/multimodal.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -474,7 +474,19 @@ def get_mrope_input_positions(
# can't accept arbitrary args, even if its value is `None`
kwargs = {}
if mm_token_type_ids:
kwargs["mm_token_type_ids"] = torch.cat(mm_token_type_ids)
if not hasattr(self, "_get_rope_index_accepts_mm_token_type_ids"):
import inspect

sig = inspect.signature(self.model.get_rope_index)
params = sig.parameters
self._get_rope_index_accepts_mm_token_type_ids = (
"mm_token_type_ids" in params
or any(
p.kind == inspect.Parameter.VAR_KEYWORD for p in params.values()
)
)
if self._get_rope_index_accepts_mm_token_type_ids:
kwargs["mm_token_type_ids"] = torch.cat(mm_token_type_ids)

mrope_positions, mrope_position_delta = self.model.get_rope_index(
input_ids=torch.tensor(input_tokens).unsqueeze(0),
Expand Down