Skip to content

[Misc] Fix typos in comments: explict→explicit, paramaters→parameters#35648

Merged
vllm-bot merged 1 commit intovllm-project:mainfrom
lin-shh:fix/typo-comments-fused-moe
Mar 3, 2026
Merged

[Misc] Fix typos in comments: explict→explicit, paramaters→parameters#35648
vllm-bot merged 1 commit intovllm-project:mainfrom
lin-shh:fix/typo-comments-fused-moe

Conversation

@lin-shh
Copy link
Copy Markdown
Contributor

@lin-shh lin-shh commented Mar 1, 2026

Fix three spelling errors in code comments across fused_moe files:

  • oracle/fp8.py and oracle/nvfp4.py: explictexplicit
  • router/router_factory.py: paramatersparameters

These are minor documentation/comment quality improvements.

cc @yewentao256

Fix three spelling errors in code comments across fused_moe files:
- oracle/fp8.py and oracle/nvfp4.py: "explict" → "explicit"
- router/router_factory.py: "paramaters" → "parameters"

Made-with: Cursor
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request corrects a few typos in the code comments. The changes from explict to explicit and paramaters to parameters are accurate and improve code readability. The pull request is good to merge.

@lin-shh
Copy link
Copy Markdown
Contributor Author

lin-shh commented Mar 1, 2026

@yewentao256 Hi! Would you mind reviewing this small PR? It fixes two typos in comments: explictexplicit and paramatersparameters. Thanks!

Copy link
Copy Markdown
Member

@yewentao256 yewentao256 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the work!

@yewentao256 yewentao256 added the ready ONLY add when PR is ready to merge/full CI is needed label Mar 1, 2026
@vllm-bot vllm-bot merged commit 35a6f0b into vllm-project:main Mar 3, 2026
62 of 64 checks passed
wendyliu235 pushed a commit to wendyliu235/vllm-public that referenced this pull request Mar 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants